-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adding extra fields #32
Conversation
Hi @mosheavni - thanks for your contribution |
sure @Doron-Bargo I'm done now.
All of these generates a valid |
f6d7eb7
to
bab7bbb
Compare
@mirii1994 @Doron-Bargo |
Hi @mosheavni thanks for your contribution! I'll review your PR in the next couple of days :) |
@mirii1994 @Doron-Bargo anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mosheavni great work!! :)
I commented out environment
& foo
in values.yaml extraFields, so that they would use an examples, bumped the chart's version, and edited some of the readme.
Please undo the linting in the README.md file.
thanks @mirii1994 |
@mosheavni please undo the linting on the README.md file, so that I can review it :) |
there was no linting made, only necessary relevant changes that reflects the changes of the code. |
Closes #31
Allows to add extra fields to the auto discover and the standard configs without having to copy the entire block.
Also some markdown linting.