fix: nil error when container doesn't have exit code (#52)

cli/cage/main.go

@@ -10,7 +10,7 @@ import (
 func main() {
 	app := cli.NewApp()
 	app.Name = "canarycage"
-	app.Version = "3.4.0"
+	app.Version = "3.4.1"
 	app.Description = "A gradual roll-out deployment tool for AWS ECS"
 	ctx := context.Background()
 	cmds := commands.NewCageCommands(ctx)

run.go

@@ -32,7 +32,7 @@ func (c *cage) Run(ctx context.Context, input *RunInput) (*RunResult, error) {
 		return nil, err
 	}
 	if !containerExistsInDefinition(td, input.Container) {
-		return nil, fmt.Errorf("'%s' not found in container definitions", *input.Container)
+		return nil, fmt.Errorf("🚫 '%s' not found in container definitions", *input.Container)
 	}
 	o, err := c.ecs.RunTaskWithContext(ctx, &ecs.RunTaskInput{
 		Cluster:              &c.env.Cluster,
@@ -69,11 +69,14 @@ func (c *cage) Run(ctx context.Context, input *RunInput) (*RunResult, error) {
 		}
 		for _, container := range task.Containers {
 			if *container.Name == *input.Container {
+				if container.ExitCode == nil {
+					return nil, fmt.Errorf("🚫 container '%s' hasn't exit", *input.Container)
+				}
 				exitCode = *container.ExitCode
 				goto next
 			}
 		}
-		return nil, fmt.Errorf("container '%s' not found in results", *input.Container)
+		return nil, fmt.Errorf("🚫 container '%s' not found in results", *input.Container)
 	}
 	return nil, fmt.Errorf("🚫 max attempts exceeded")
 next:

run_test.go

@@ -138,6 +138,37 @@ func TestCage_Run(t *testing.T) {
 		assert.Nil(t, result)
 		assert.EqualError(t, err, "🚫 task exited with 1")
 	})
+	t.Run("should error if exit code is nil", func(t *testing.T) {
+		env := DefaultEnvars()
+		ctrl := gomock.NewController(t)
+		defer ctrl.Finish()
+		overrides := &ecs.TaskOverride{}
+		container := "container"
+		ctx := context.Background()
+		ecsMock := setupForBasic(ctx, ctrl, []*ecs.DescribeTasksOutput{
+			{Tasks: []*ecs.Task{
+				{LastStatus: aws.String("STOPPED"),
+					Containers: []*ecs.Container{{
+						Name:     &container,
+						ExitCode: nil,
+					}}},
+			}},
+		})
+		cagecli := NewCage(&Input{
+			Env: env,
+			ECS: ecsMock,
+			ALB: nil,
+			EC2: nil,
+		})
+		newTimer = fakeTimer
+		defer recoverTimer()
+		result, err := cagecli.Run(ctx, &RunInput{
+			Container: &container,
+			Overrides: overrides,
+		})
+		assert.Nil(t, result)
+		assert.EqualError(t, err, "🚫 container 'container' hasn't exit")
+	})
 	t.Run("should error if container doesn't exist in definition", func(t *testing.T) {
 		ctrl := gomock.NewController(t)
 		defer ctrl.Finish()
@@ -166,6 +197,6 @@ func TestCage_Run(t *testing.T) {
 			Overrides: overrides,
 		})
 		assert.Nil(t, result)
-		assert.EqualError(t, err, "'foo' not found in container definitions")
+		assert.EqualError(t, err, "🚫 'foo' not found in container definitions")
 	})
 }