feat: cage rollout --updateService #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
- Coverage 75.74% 74.03% -1.72%
==========================================
Files 18 16 -2
Lines 969 882 -87
==========================================
- Hits 734 653 -81
+ Misses 136 133 -3
+ Partials 99 96 -3 ☔ View full report in Codecov by Sentry. |
This was referenced Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently introduced
cage recreatecommand has been reverted. Instead of that, we introduce--updateServiceoption tocage rolloutcommand. That applies service configurations (load balancer, networks, etc...) in definition to existing service. This flag is optional and set tofalseby default.And, fixed the bug that canary task remains after canary test. This situation is caused by an unexpected error during registering task into ALB target.