Skip to content

Commit

Permalink
Merge branch 'main' into api-common_release_pipeline
Browse files Browse the repository at this point in the history
  • Loading branch information
CarlosGamero committed Mar 21, 2024
2 parents 2dae95d + 60f8823 commit c316873
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 13 deletions.
2 changes: 1 addition & 1 deletion packages/app/websockets-common/src/rooms.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export type Room<Rn extends RoomName> = Rooms[Rn]
*/
export type RoomId = `${RoomName}|${string}`

const SEPARATOR = '|' as const
const SEPARATOR = '|'

export const getRoomId = <Rn extends RoomName>(
roomName: Rn,
Expand Down
5 changes: 0 additions & 5 deletions packages/dev/eslint-config/configs/frontend.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@ module.exports = {
browser: true,
node: true,
},
settings: {
jest: {
version: '>= 27',
},
},
rules: {
'import/no-extraneous-dependencies': ['error', { packageDir: './' }],
},
Expand Down
4 changes: 1 addition & 3 deletions packages/dev/eslint-config/configs/shared-package.cjs
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
module.exports = {
ignorePatterns: ['node_modules', 'dist'],
plugins: ['@typescript-eslint', 'prettier', 'vitest', 'import'],
plugins: ['@typescript-eslint', 'vitest', 'import'],
extends: [
'eslint:recommended',
'plugin:prettier/recommended',
'plugin:import/recommended',
'plugin:import/typescript',
'plugin:vitest/recommended',
'./typescript.cjs',
'./tests.cjs',
],
rules: {
'prettier/prettier': 'error',
// Disabling since rule has a bug where it has false positive when named export matches module name
'import/no-named-as-default': 'off',
'import/no-named-as-default-member': 'off',
Expand Down
8 changes: 4 additions & 4 deletions packages/dev/eslint-config/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lokalise/eslint-config",
"version": "1.0.0",
"version": "1.0.1",
"type": "module",
"files": [
"configs/*"
Expand All @@ -20,9 +20,9 @@
"lint:fix": "prettier --write ."
},
"dependencies": {
"@lokalise/eslint-config-frontend": "^4.1.0",
"@tanstack/eslint-plugin-query": "^5.6.0",
"@typescript-eslint/parser": "^6.13.1"
"@lokalise/eslint-config-frontend": "^4.4.0",
"@tanstack/eslint-plugin-query": "^5.28.6",
"@typescript-eslint/parser": "^7.3.1"
},
"devDependencies": {
"@lokalise/prettier-config": "*",
Expand Down

0 comments on commit c316873

Please sign in to comment.