Universal-ts-utils preparing internal utils folder (#376)

* Creating external folder

* Extracting compare to a new internal file and reusing it

* Name change

packages/app/universal-ts-utils/package.json

@@ -44,9 +44,9 @@
             "import": "./dist/node.js"
         },
         "./*": {
-            "types": "./dist/*.d.ts",
-            "import": "./dist/*",
-            "require": "./dist/*"
+            "types": "./dist/public/*.d.ts",
+            "import": "./dist/public/*",
+            "require": "./dist/public/*"
         },
         "./package.json": "./package.json"
     }

packages/app/universal-ts-utils/src/internal/compare.spec.ts

@@ -0,0 +1,30 @@
+import { describe, expect, it } from 'vitest'
+import { compare } from './compare'
+
+describe('compare', () => {
+  it('should correctly compare two strings', () => {
+    expect(compare('apple', 'banana')).toBeLessThan(0)
+    expect(compare('orange', 'orange')).toBe(0)
+    expect(compare('zebra', 'apple')).toBeGreaterThan(0)
+  })
+
+  it('should correctly compare two numbers', () => {
+    expect(compare(1, 2)).toBeLessThan(0)
+    expect(compare(10, 10)).toBe(0)
+    expect(compare(15, 5)).toBeGreaterThan(0)
+  })
+
+  it('should handle comparison of same strings', () => {
+    expect(compare('test', 'test')).toBe(0)
+  })
+
+  it('should handle comparison of same numbers', () => {
+    expect(compare(42, 42)).toBe(0)
+  })
+
+  it('should handle comparison with empty strings', () => {
+    expect(compare('', 'a')).toBeLessThan(0)
+    expect(compare('a', '')).toBeGreaterThan(0)
+    expect(compare('', '')).toBe(0)
+  })
+})

packages/app/universal-ts-utils/src/internal/compare.ts

@@ -0,0 +1,12 @@
+export const compare = <T extends string | number>(a: T, b: T): number => {
+  let result = 0
+  if (typeof a === 'string' && typeof b === 'string') {
+    // Sort strings using localeCompare
+    result = a.localeCompare(b)
+  } else if (typeof a === 'number' && typeof b === 'number') {
+    // Sort numbers using basic comparison
+    result = a - b
+  }
+
+  return result
+}

packages/app/universal-ts-utils/src/node.ts

@@ -1,15 +1,15 @@
 // We don't want to have a typical index file due to how FE bundlers work. Please see `readme` for more info.
 
 // array
-export * from './array/areStringArraysEqual.js'
-export * from './array/chunk.js'
-export * from './array/callChunked.js'
-export * from './array/isNonEmptyArray.js'
-export * from './array/removeFalsy.js'
-export * from './array/removeNullish.js'
-export * from './array/unique.js'
-export * from './array/sort.js'
-export * from './array/sortByField.js'
+export * from './public/array/areStringArraysEqual.js'
+export * from './public/array/chunk.js'
+export * from './public/array/callChunked.js'
+export * from './public/array/isNonEmptyArray.js'
+export * from './public/array/removeFalsy.js'
+export * from './public/array/removeNullish.js'
+export * from './public/array/unique.js'
+export * from './public/array/sort.js'
+export * from './public/array/sortByField.js'
 
 // object
-export * from './object/areDeepEqual.js'
+export * from './public/object/areDeepEqual.js'

packages/app/universal-ts-utils/src/array/sort.ts → packages/app/universal-ts-utils/src/public/array/sort.ts

@@ -1,3 +1,5 @@
+import { compare } from '../../internal/compare'
+
 /**
  * Sorts an array of strings or numbers in either ascending or descending order.
  *
@@ -18,16 +20,3 @@ export const sort = <T extends string[] | number[]>(array: T, order: 'asc' | 'de
     order === 'asc' ? copy.sort((a, b) => compare(a, b)) : copy.sort((a, b) => compare(b, a))
   ) as T
 }
-
-const compare = <T extends string | number>(a: T, b: T): number => {
-  let result = 0
-  if (typeof a === 'string' && typeof b === 'string') {
-    // Sort strings using localeCompare
-    result = a.localeCompare(b)
-  } else if (typeof a === 'number' && typeof b === 'number') {
-    // Sort numbers using basic comparison
-    result = a - b
-  }
-
-  return result
-}

packages/app/universal-ts-utils/src/array/sortByField.ts → packages/app/universal-ts-utils/src/public/array/sortByField.ts

@@ -1,3 +1,5 @@
+import { compare } from '../../internal/compare'
+
 type KeysMatching<T extends object, V> = {
   [K in keyof T]: T[K] extends V ? K : never
 }[keyof T]
@@ -43,16 +45,3 @@ export const sortByField = <T extends object, K extends KeysMatching<T, string |
     ? copy.sort((a, b) => compare(a[field] as string | number, b[field] as string | number))
     : copy.sort((a, b) => compare(b[field] as string | number, a[field] as string | number))
 }
-
-const compare = <T extends string | number>(a: T, b: T): number => {
-  let result = 0
-  if (typeof a === 'string' && typeof b === 'string') {
-    // Sort strings using localeCompare
-    result = a.localeCompare(b)
-  } else if (typeof a === 'number' && typeof b === 'number') {
-    // Sort numbers using basic comparison
-    result = a - b
-  }
-
-  return result
-}