Add type guards for errors #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
requested review from
rupert-mckay,
CarlosGamero and
dariacm
as code owners
arthuracs
reviewed
Dec 4, 2023
| } | ||
|
|
||
| export function isAutopilotError(error: unknown): error is AutopilotError { | ||
| return isObject(error) && typeof error.errorCode === 'string' && typeof error.message === 'string' |
There was a problem hiding this comment.
I think the errorCode is part of the message, e.g.:
{
"response": {
"cause": {},
"response": {},
"url": "http://api.autopilot.local/v1/projects/17d18e41-d104-4053-88c3-f052037d7a94/integrations/git",
"message": "{\"message\":\"Integration not found\",\"errorCode\":\"ENTITY_NOT_FOUND\"}",
"json": {
"message": "Integration not found",
"errorCode": "ENTITY_NOT_FOUND"
},
"text": "{\"message\":\"Integration not found\",\"errorCode\":\"ENTITY_NOT_FOUND\"}",
"status": 404
}
}There was a problem hiding this comment.
Discussed with Arthur offline. We can do the check like this:
if (isAutopilotError(response.json))
However, we already can do this as well:
const autopilotError = COMMON_ERROR_RESPONSE_SCHEMA.parse(response.json)
@szymonchudy @ondrejsevcik Thoughts on whether we need the type guard, or just the schema is sufficient?
CarlosGamero
approved these changes
Dec 5, 2023
arthuracs
approved these changes
Dec 13, 2023
…o feat/error-type-guards # Conflicts: # packages/app/api-common/package.json
|
Currently blocked by https://github.com/lokalise/node-core/pull/89/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.