Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-3965 Vault fetch #177

Merged
merged 21 commits into from
Jun 18, 2024
Merged

AP-3965 Vault fetch #177

merged 21 commits into from
Jun 18, 2024

Conversation

kamilwylegala
Copy link
Contributor

@kamilwylegala kamilwylegala commented Jun 17, 2024

Changes

Script utility for fetching secrets from provided vault instance + merging them into configured .env file.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kamilwylegala kamilwylegala changed the title Ap 3965 vault fetch AP-3965 Vault fetch Jun 17, 2024
@kamilwylegala kamilwylegala marked this pull request as ready for review June 17, 2024 12:42
Copy link
Collaborator

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is awesome!

Copy link
Collaborator

@CarlosGamero CarlosGamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamilwylegala could you please add the release workflow as we have for the other libs 🙏? You can take the others as examples and let me know if you have problems

@kamilwylegala
Copy link
Contributor Author

@kamilwylegala could you please add the release workflow as we have for the other libs 🙏? You can take the others as examples and let me know if you have problems

Sure. let me check what it is about.

@kamilwylegala
Copy link
Contributor Author

@CarlosGamero Done, I used id-utils as a base config.

@CarlosGamero
Copy link
Collaborator

Outstanding! Thank youuu 🙌

@kamilwylegala kamilwylegala merged commit 97ca4f7 into main Jun 18, 2024
3 checks passed
@kamilwylegala kamilwylegala deleted the AP-3965_vault_fetch branch June 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants