-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
id-utils biome #270
Merged
Merged
id-utils biome #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Aug 9, 2024
@@ -5,7 +5,6 @@ import defineConfig from '@lokalise/package-vite-config/package' | |||
// @ts-ignore | |||
import packageJson from './package.json' | |||
|
|||
/* eslint-disable import/no-default-export */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need a biome override here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not ask me why, but is not needed on vitest.config
override, maybe it is disabled by default on biome
kibertoad
reviewed
Aug 9, 2024
kibertoad
reviewed
Aug 9, 2024
CarlosGamero
force-pushed
the
chore/id-utils_biome
branch
from
August 9, 2024 08:17
58bcfb1
to
baec41b
Compare
CarlosGamero
requested review from
dariacm,
ondrejsevcik and
a team
as code owners
August 9, 2024 08:38
kibertoad
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
major
,minor
,patch
orskip-release