Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id-utils biome #270

Merged
merged 4 commits into from
Aug 9, 2024
Merged

id-utils biome #270

merged 4 commits into from
Aug 9, 2024

Conversation

CarlosGamero
Copy link
Collaborator

@CarlosGamero CarlosGamero commented Aug 9, 2024

Changes

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@@ -5,7 +5,6 @@ import defineConfig from '@lokalise/package-vite-config/package'
// @ts-ignore
import packageJson from './package.json'

/* eslint-disable import/no-default-export */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need a biome override here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ask me why, but is not needed on vitest.config override, maybe it is disabled by default on biome

@CarlosGamero CarlosGamero marked this pull request as ready for review August 9, 2024 08:38
@CarlosGamero CarlosGamero merged commit 1b07801 into main Aug 9, 2024
5 checks passed
@CarlosGamero CarlosGamero deleted the chore/id-utils_biome branch August 9, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants