AP-5778 introduce prisma metrics plugin #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dosexe
commented
Oct 29, 2024
| this.metrics.gauges[gaugeMetric.key]?.set(gaugeMetric.value) | ||
| } | ||
| for (const histogramMetric of jsonMetrics.histograms) { | ||
| this.metrics.histograms[histogramMetric.key]?.observe(histogramMetric.value.sum) |
There was a problem hiding this comment.
not sure what is the proper way to work with histograms, prometheus provide only observe function to pass one number value, while prisma provide 2 values -> sum and count
Dosexe
requested review from
kibertoad,
CarlosGamero,
dariacm,
ondrejsevcik and
a team
as code owners
Dosexe
commented
Oct 30, 2024
| metricsPrefix: string | ||
| } | ||
|
|
||
| function registerMetrics(_prefix: string, jsonMetrics: Metrics): PrometheusMetricsDefinitions { |
There was a problem hiding this comment.
_prefix is provided but not used, since all already prefix with prisma_, but I would leave the value in case we want to use it in future
Dosexe
commented
Oct 30, 2024
| metrics.counters[metric.key] = new prometheus.Counter({ | ||
| name: metric.key, | ||
| help: metric.description, | ||
| labelNames: ['prisma', 'connection_pool'] as const, |
There was a problem hiding this comment.
prisma has its own labels, we can use them instead + add our prisma label, not all metrics are related to connection pool
kibertoad
approved these changes
Oct 30, 2024
CarlosGamero
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe
Checklist
major,minor,patchorskip-release