Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding common release pipeline #69

Merged
merged 15 commits into from
Apr 2, 2024

Conversation

CarlosGamero
Copy link
Collaborator

@CarlosGamero CarlosGamero commented Mar 22, 2024

Changes

Adding a common pipeline to avoid boilerplate code needed on release pipelines, also, using it with websockets-common to be able to test it and check if it is really working

Checklist

@CarlosGamero CarlosGamero self-assigned this Mar 22, 2024
@CarlosGamero CarlosGamero changed the title Feature/adding common release pipeline Adding common release pipeline Mar 22, 2024
@CarlosGamero CarlosGamero changed the title Adding common release pipeline [IN PROGRESS] Adding common release pipeline Mar 22, 2024
@CarlosGamero CarlosGamero changed the title [IN PROGRESS] Adding common release pipeline Adding common release pipeline Mar 25, 2024
@CarlosGamero CarlosGamero marked this pull request as ready for review March 25, 2024 08:40
Comment on lines +1 to +14
name: Package release to NPM
on:
workflow_call:
inputs:
working_directory:
required: true
type: string
package_name:
required: true
type: string
secrets:
npm_token:
required: true

Copy link
Collaborator Author

@CarlosGamero CarlosGamero Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, I will update api-common release and add the pipeline for all the other packages

@CarlosGamero CarlosGamero marked this pull request as draft March 26, 2024 14:34
@CarlosGamero
Copy link
Collaborator Author

The base pipeline is failing, putting as draft in the meantime we apply the required changes

@CarlosGamero CarlosGamero marked this pull request as ready for review April 1, 2024 16:42
Copy link
Collaborator

@dariacm dariacm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos @CarlosGamero, you're the best ❤️

@CarlosGamero CarlosGamero merged commit 2dbd660 into main Apr 2, 2024
4 of 5 checks passed
@CarlosGamero CarlosGamero deleted the feature/adding_common_release_pipeline branch April 2, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants