Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lokui: GUI framework experiment #5
base: main
Are you sure you want to change the base?
Lokui: GUI framework experiment #5
Changes from 29 commits
468dc30
6054eef
cb469f6
3a73fb4
432a955
acd189a
502494e
6ebb16a
38d06ca
ed737bb
e9dc989
b88dd1e
25fce4f
ad39404
bd6c2b9
29e6b54
4bd9b0e
46d59e4
008451f
8726f8b
73d659e
f5a05dc
a1350ff
d1174ba
fee22f3
045e040
cc6e3b6
e8fa294
6b34435
547580c
241aad8
1b36d4f
7edfde9
a927665
289f752
6393c0d
1aed813
27f1aed
b2a4f5f
58f247d
363a9f0
9a7247a
8fcefa3
cf11755
3845d90
6b6cb6e
3fdf34b
bbd32b9
6508348
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A way to avoid writing almost the same thing three separate times would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol I didn't bother not repeating. xD
It's also not exactly the same thing. One is a text inside a pane, one is a
+1
button, the other is a-1
button. The thing that could avoid some repetition here at best would be the button layouts, because they are the exact same... Which would make it slightly better since thewith_layout
bit takes the most space I guess :vThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, layout is what I meant to be referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah alright