Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc context | cache fixes #1641

Merged
merged 6 commits into from
Sep 7, 2023
Merged

misc context | cache fixes #1641

merged 6 commits into from
Sep 7, 2023

Conversation

lolopinto
Copy link
Owner

follow-up to #1635

  • use context in a few places that were missing e.g. operations.ts
  • consolidate types in one place
  • add join to cache.QueryOptions and what it's checking
  • use loader factory instead of loader in a bunch of tests so it's similar to production use cases
  • clear out as many manual cache clearing as possible. if the cache has to be manually cleared, it's a sign that something is broken and fixed it e.g. missing context or context not threaded through
  • probably more

may be worth doing a breaking change to make Context required but cache can be optional to imrp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant