dock: Add cache to panel view. (#600)

longbridge · Feb 5, 2025 · 9675f1e · 9675f1e
1 parent 3e16c0d
commit 9675f1e
Show file tree

Hide file tree

Showing 4 changed files with 205 additions and 188 deletions.
diff --git a/crates/story/src/table_story.rs b/crates/story/src/table_story.rs
@@ -33,8 +33,8 @@ impl_internal_actions!(table_story, [ChangeSize, OpenDetail]);
 #[derive(Clone, Debug, Default)]
 struct Stock {
     id: usize,
-    symbol: String,
-    name: String,
+    symbol: SharedString,
+    name: SharedString,
     price: f64,
     change: f64,
     change_percent: f64,
@@ -103,8 +103,8 @@ fn random_stocks(size: usize) -> Vec<Stock> {
     (0..size)
         .map(|id| Stock {
             id,
-            symbol: Faker.fake::<String>(),
-            name: Faker.fake::<String>(),
+            symbol: Faker.fake::<String>().into(),
+            name: Faker.fake::<String>().into(),
             change: (-100.0..100.0).fake(),
             change_percent: (-1.0..1.0).fake(),
             volume: (0.0..1000.0).fake(),

diff --git a/crates/ui/src/dock/dock.rs b/crates/ui/src/dock/dock.rs
@@ -3,9 +3,10 @@
 use std::sync::Arc;
 
 use gpui::{
-    div, prelude::FluentBuilder as _, px, App, AppContext, Axis, Context, Element, Empty, Entity,
-    InteractiveElement as _, IntoElement, MouseMoveEvent, MouseUpEvent, ParentElement as _, Pixels,
-    Point, Render, StatefulInteractiveElement, Style, Styled as _, WeakEntity, Window,
+    div, prelude::FluentBuilder as _, px, AnyView, App, AppContext, Axis, Context, Element, Empty,
+    Entity, InteractiveElement as _, IntoElement, MouseMoveEvent, MouseUpEvent, ParentElement as _,
+    Pixels, Point, Render, StatefulInteractiveElement, Style, StyleRefinement, Styled as _,
+    WeakEntity, Window,
 };
 use serde::{Deserialize, Serialize};
 
@@ -394,6 +395,8 @@ impl Render for Dock {
             return div();
         }
 
+        let cache_style = StyleRefinement::default().v_flex().size_full();
+
         div()
             .relative()
             .overflow_hidden()
@@ -408,8 +411,10 @@ impl Render for Dock {
             })
             .map(|this| match &self.panel {
                 DockItem::Split { view, .. } => this.child(view.clone()),
-                DockItem::Tabs { view, .. } => this.child(view.clone()),
-                DockItem::Panel { view, .. } => this.child(view.clone().view()),
+                DockItem::Tabs { view, .. } => {
+                    this.child(AnyView::from(view.clone()).cached(cache_style))
+                }
+                DockItem::Panel { view, .. } => this.child(view.clone().view().cached(cache_style)),
                 // Not support to render Tiles and Tile into Dock
                 DockItem::Tiles { .. } => this,
             })

diff --git a/crates/ui/src/dock/tab_panel.rs b/crates/ui/src/dock/tab_panel.rs
@@ -4,7 +4,7 @@ use gpui::{
     div, prelude::FluentBuilder, px, rems, App, AppContext, Context, Corner, DefiniteLength,
     DismissEvent, DragMoveEvent, Empty, Entity, EventEmitter, FocusHandle, Focusable,
     InteractiveElement as _, IntoElement, ParentElement, Pixels, Render, ScrollHandle,
-    SharedString, StatefulInteractiveElement, Styled, WeakEntity, Window,
+    SharedString, StatefulInteractiveElement, StyleRefinement, Styled, WeakEntity, Window,
 };
 use rust_i18n::t;
 
@@ -14,7 +14,7 @@ use crate::{
     h_flex,
     popup_menu::{PopupMenu, PopupMenuExt},
     tab::{Tab, TabBar},
-    v_flex, ActiveTheme, AxisExt, IconName, Placement, Selectable, Sizable,
+    v_flex, ActiveTheme, AxisExt, IconName, Placement, Selectable, Sizable, StyledExt as _,
 };
 
 use super::{
@@ -767,7 +767,11 @@ impl TabPanel {
             .overflow_y_scroll()
             .overflow_x_hidden()
             .flex_1()
-            .child(active_panel.view())
+            .child(
+                active_panel
+                    .view()
+                    .cached(StyleRefinement::default().v_flex().size_full()),
+            )
             .when(state.droppable, |this| {
                 this.on_drag_move(cx.listener(Self::on_panel_drag_move))
                     .child(