Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to support open Popover as a child window. #18

Merged
merged 16 commits into from
Jul 11, 2024
Merged

Conversation

huacnlee
Copy link
Member

@huacnlee huacnlee commented Jul 9, 2024

Goal

Change to let Popup elements open into a window, to make sure the Popup windows, panels, menus render top than the WebView.

Then we can embed wry or other webview into GPUI.

CleanShot.2024-07-11.at.11.53.16.mp4

This is also like other software, they are also used in child window to render the menus, popups.

Todos

  • Multiple display window position.
  • Windows transparent background. (No transparent, just render a correct window border)
  • Disable window resize on Windows.
  • Handle Menu action.
  • Provided popover or window two mode to uses.

@huacnlee huacnlee changed the title Window popover Use Child Window to show Popover Jul 9, 2024
@huacnlee
Copy link
Member Author

huacnlee commented Jul 9, 2024

CleanShot.2024-07-09.at.20.45.22.mp4

@huacnlee
Copy link
Member Author

huacnlee commented Jul 9, 2024

2024-07-09.211919.mp4

On Windows, now the Popover position is right, but the window size not correct.

@huacnlee
Copy link
Member Author

huacnlee commented Jul 9, 2024

2024-07-09.213837.mp4

@huacnlee huacnlee changed the title Use Child Window to show Popover Add to support open Popover as a child window. Jul 11, 2024
@huacnlee huacnlee merged commit eb43c78 into main Jul 11, 2024
@huacnlee huacnlee deleted the window-popover branch July 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant