fix(monitor): make the warning and error messages more clear

Longhorn 10035 Signed-off-by: Derek Su <[email protected]> (cherry picked from commit c921e2b) # Conflicts: # controller/monitor/environment_check_monitor.go
longhorn · Dec 23, 2024 · 799bdf0 · 799bdf0
1 parent baee42f
commit 799bdf0
Show file tree

Hide file tree

Showing 2 changed files with 568 additions and 1 deletion.
diff --git a/controller/monitor/disk_monitor.go b/controller/monitor/disk_monitor.go
@@ -98,7 +98,11 @@ func (m *NodeMonitor) Start() {
 		}
 		return false, nil
 	}); err != nil {
-		m.logger.WithError(err).Error("Failed to start node monitor")
+		if errors.Is(err, context.Canceled) {
+			m.logger.WithError(err).Warning("Disk monitor is stopped")
+		} else {
+			m.logger.WithError(err).Error("Failed to start disk monitor")
+		}
 	}
 }
 
@@ -129,6 +133,7 @@ func (m *NodeMonitor) GetCollectedData() (interface{}, error) {
 func (m *NodeMonitor) run(value interface{}) error {
 	node, err := m.ds.GetNode(m.nodeName)
 	if err != nil {
+		logrus.WithError(err).Errorf("Failed to get longhorn node %v", m.nodeName)
 		return errors.Wrapf(err, "failed to get longhorn node %v", m.nodeName)
 	}