-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(monitor): set monitors to nil after closing them (backport #3388) #3396
Conversation
Longhorn 10035 Signed-off-by: Derek Su <[email protected]> (cherry picked from commit c921e2b) # Conflicts: # controller/monitor/environment_check_monitor.go
No need to delay the environment check. Longhorn 10035 Signed-off-by: Derek Su <[email protected]> (cherry picked from commit c410f5d)
Cherry-pick of c921e2b has failed:
Cherry-pick of a65a6ce has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
790b6dc
to
039ca84
Compare
Set monitors to nil after closing them, so the controller can recreate them when the node is back. Longhorn 10035 Signed-off-by: Derek Su <[email protected]> (cherry picked from commit a65a6ce)
039ca84
to
d5c9d90
Compare
Mistakenly add |
Which issue(s) this PR fixes:
Issue longhorn/longhorn#10035
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
This is an automatic backport of pull request #3388 done by [Mergify](https://mergify.com).