fix(monitor): remove the close of monitors

[derekbit]

Which issue(s) this PR fixes:

Issue longhorn/longhorn#10035

What this PR does / why we need it:

No need to close the monitors after deleting a node resource. If a node is gone, monitor will return error and won't continue the following tasks.

e2e
https://ci.longhorn.io/job/private/job/longhorn-e2e-test/2295/console

Special notes for your reviewer:

Additional documentation or context

[coderabbitai]

Walkthrough

The pull request introduces modifications to error handling in the DiskMonitor and NodeController components. In the disk_monitor.go file, error reporting is enhanced by using errors.Wrapf to provide more context when errors occur. In the node_controller.go file, the changes involve removing the explicit stopping of disk, environment check, and snapshot monitors during node deletion, which may impact resource management during node lifecycle operations.

Changes

File	Change Summary
controller/monitor/disk_monitor.go	- Updated error handling in run method to use errors.Wrapf for more informative error messages - Improved error message construction in collectDiskData method
controller/node_controller.go	- Removed monitor stopping logic during node deletion in syncNode method - Retained node status update and error logging mechanisms

Assessment against linked issues

Objective	Addressed	Explanation
Resolve disk addition issues after node deletion and re-addition [#10035]	❓	Potential impact on node and disk monitoring, but direct resolution is unclear

Possibly related PRs

• fix: move environment checks to a dedicated monitor #3369: Changes to error handling in BackupBackingImageController
• fix(monitor): set monitors to nil after closing them #3388: Modifications to disk_monitor.go error handling

Suggested reviewers

• COLDTURNIP
• innobead
• ChanYiLin
• c3y1huang
• mantissahz

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a65a6ce and d82d849.

📒 Files selected for processing (2)

• controller/monitor/disk_monitor.go (0 hunks)
• controller/node_controller.go (0 hunks)

💤 Files with no reviewable changes (2)

• controller/monitor/disk_monitor.go
• controller/node_controller.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[derekbit]

@mergify backport v1.8.x

[mergify]

backport v1.8.x

✅ Backports have been created

• #3398 fix(monitor): remove the close of monitors (backport #3397) has been created for branch v1.8.x