-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove default backup target settings (backport #3414) #3418
Conversation
ref: longhorn/longhorn 5411, 10043 Signed-off-by: Derek Su <[email protected]> (cherry picked from commit 758d1c5)
And add missing changes when fixing 7159. ref: longhorn/longhorn 5411, 7159, 10043 Signed-off-by: James Lu <[email protected]> (cherry picked from commit 0dafa29)
instead of `NodeHasDefaultEngineImage` because we should allow to modify a backup target without the `default` engine image. ref: longhorn/longhorn 5411, 10043 Signed-off-by: James Lu <[email protected]> (cherry picked from commit 0ac13db)
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which issue(s) this PR fixes:
Issue longhorn/longhorn#10043
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
This is an automatic backport of pull request #3414 done by [Mergify](https://mergify.com).