Add support for doctrine/orm 3.0 #43

captain-igloo · 2024-02-13T02:45:15Z

doctrine/orm 3.0 was released a few days ago. Would it be possible to add support for this?

Thanks

Alexandre-T · 2024-03-12T20:05:00Z

I am currently forking and updating libraries (geo-parser and wkt-parser) required to migrate to doctrine/lexer:3. The goal is to make doctrine-spatial compatible with doctrine/orm:3.

lukena-xxl · 2024-03-13T13:00:49Z

Hello. When can we expect support for "doctrine/orm 3.1"? Thank you

Alexandre-T · 2024-03-13T17:40:42Z

I don't know. I am a volunteer, doing this in my spare time, and I haven't yet studied the impact between doctrine:orm 2.0 and ~~doctrine:orm 3.0, let alone~~ Doctrine 3.1.

Alexandre-T · 2024-03-24T19:34:36Z

longitude/geo-parser is done.
Todo :

longitude-one/wkt-parser
doctrine/orm:3

Alexandre-T · 2024-03-31T14:17:47Z

longitude-one/geo-parser is upgraded. A pre-release 3.0.0.RC is published, it's compatible with doctrine/lexer:3.0
longitude-one/wkt-parser is upgraded. A pre-release 3.0.0.RC is published, it's compatible with doctrine/lexer:3.0 (and experimental 3.1)

I can now focus on longitude-one/doctrine-spatial

Todo :

Fork creof/wkb-parser
Upgrade longitude-one/wkb-parser
Fix deprecations on longitude-one/doctrine-spatial with the last versions doctrine/orm:2.* (2.19.3 today)
Upgrade longitude-one/doctrine-spatial to be compliant with the last versions of doctrine/orm:3.1.* (3.1.1 today)
Have a look on doctrine/orm:3.2
Have a look on doctrine/orm:4.0

remy-theroux · 2024-04-05T10:07:04Z

thanks for your time

danielgwood · 2024-04-10T06:28:09Z

Thanks for your time. If you have a Ko-fi or similar I'd love to make a donation, it's a helpful package.

Alexandre-T · 2024-04-10T20:43:11Z

Thanks for your time. If you have a Ko-fi or similar I'd love to make a donation, it's a helpful package.

Thank you very much @danielgwood : ko-fi.com/alexandret

longitude-one/geo-parser is upgraded. A pre-release 3.0.0.RC is published, it's compatible with doctrine/lexer:3.0
longitude-one/wkt-parser is upgraded. A pre-release 3.0.0.RC is published, it's compatible with doctrine/lexer:3.0 (and experimental 3.1)
longitude-one/wkb-parser is upgraded. A pre-release 3.0.0.RC is published (no dependencies)

All CrEOF libraries have been replaced (thanks for their initial work) by the longitude-one ones.
I now focus on longitude-one/doctrine-spatial. The doctrine3-feature branch is pushed. The CI is working! A lot of deprecation are thrown as expected, but it will help me to fix everything!

Todo :

~~Fork creof/wkb-parser~~
~~Upgrade longitude-one/wkb-parser~~
~~Fix deprecations on longitude-one/doctrine-spatial with the last versions of longitude-one/*parser libraries~~
~~Fix deprecations on longitude-one/doctrine-spatial with the last versions doctrine/orm:2.* (2.19.3 today)~~
~~Upgrade longitude-one/doctrine-spatial to be compliant with the "old" versions of doctrine/orm:3.0.*~~
Upgrade longitude-one/doctrine-spatial to be compliant with the last versions of doctrine/orm:3.1.* (3.1.1 today)
Have a look on doctrine/orm:3.2
Have a look on doctrine/orm:4.0

Alexandre-T · 2024-04-26T20:09:02Z

I'm about to create a pull request on the dev branch, targeting a merge with main. This will release longitude-one:doctrine-spatial/4.1.0. This version remains "only" compatible with doctrine/orm:2.19.

Good News!

I've made significant progress! Because the curent branch is already compatible with doctrine/orm:3.0, and all tests are passing successfully. I only have to update the composer.json. (ie: I already did the job 🎉🎉 )
The three dependencies, longitude-one/*-parser:3.0.0.RC, are working flawlessly. I plan to publish them as version 3.0.0 this weekend. (done)
Following that, I'll focus on compatibility with doctrine/orm:3.1. In my estimation, this should only take a few hours of development. (done)
Once compatibility is achieved, I'll be able to publish longitude-one:doctrine-spatial/5.0.0.RC.

Target Release Date:

Based on my progress, I'm confident I can publish the 5.0.0 release candidate version by May 14th.
The final release will depend on your feedbacks.

## Doctrine 3 Feature * Compatibility with doctrine/orm:2.19 * Compatibility with doctrine/orm:3.1 * Compatibility tested (and currently working) with doctrine/orm:3.2.x-dev * Compatibility tested (and currently working) with doctrine/orm:4.0.x-dev * Fixing #40 * Fixing #42 * Fixing #43 * Fixing #55 ## List of commits * Composer upgrade feature (#47) * PHP-Code-sniffer upgraded * Composer upgraded (internal) * Github Actions upgraded * Using last stable version of geo-parser and wkt-parser * Using last stable version of longitude-one/wkb-parser instead of creof/wkb-parser * Upgrading to Phpunit 10 to be able to stop tests on deprecation * Fixing deprecations from geo-parser * Fixing hosts and ports * Restoring code coverage * Add pcov for code coverage * Fixing a bug * TODO check the code coverage * pcov added in PHP * Fixing directory for code coverage * Fixing directory for code coverage * PHP-CS-FIXER * Quality code steps * Deprecated method getName() removed Issue #40 fixed * Some deprecated calls removed, Deprecated File SQL Logger replaced, Unused methods removed * Ormtest split feature (#52) * Some deprecated calls removed, Deprecated File SQL Logger replaced, Unused methods removed * Logger class declared outside of OrmTestCase.php * Truncate tables before each test * Removing method * Quality code improved * Typo * Decrease OrmTestCase class complexity * Phpunit files updated * Removing 'else' expressions * Improving quality code * Test were not executed * Message fixed * Typo fixed * Class-string called without a string * MySql replaced with MySQL * All internal exceptions implements ExceptionInterface. * Fixing comment * Issue #42 fixed (#53) * test to reproduce issue added * Fixing test * Issue #42 fixed * Issue 12 (#54) * Removing travis directories and files * Creating a new composer script to create code coverage in cov format * Merging *.cov into a clover.xml file * Fixing coveralls.io * Fixing issues with doctrine/orm:3.0 * Adding "with all dependencies" option * Adding test with doctrine/orm:4.1.x-dev * Headers updated * README.md updated

remy-theroux · 2024-04-29T06:14:12Z

Good job, thank you that we encourage us to migrate to doctrine 3 ;-)

manaka02 · 2024-04-29T11:53:22Z

Thank you very much !!

tiapnn · 2024-04-29T14:49:24Z

Cheers 🍻

Alexandre-T · 2024-04-29T17:45:18Z

Thanks for your messages! Don't hesitate to give me feedback on the migration process for your applications. My demo application migrated without errors, but I only use a limited portion of the library and just the PostgreSQL engine.

captain-igloo · 2024-04-29T22:51:59Z

Thanks for your work on this. I have found:

the 5.0.0.RC release still depends on doctrine/orm 2
AbstractPoint.php has "TODO remove this line in version 5"
Previously longitude-one/wkt-parser returned float, now returns string, eg:

$parser = new \LongitudeOne\Geo\WKT\Parser();
$point = $parser->parse('POINT(174 -39.1)');

$point['value'][1] should be float but is now a string "-39.1"

remy-theroux · 2024-04-30T06:30:40Z

Thanks for your work on this. I have found:

* the 5.0.0.RC release still depends on doctrine/orm 2

* AbstractPoint.php has ["TODO remove this line in version 5"](https://github.com/longitude-one/doctrine-spatial/blob/dev/lib/LongitudeOne/Spatial/PHP/Types/AbstractPoint.php#L149)

* Previously longitude-one/wkt-parser returned float, now returns string, eg:

$parser = new \LongitudeOne\Geo\WKT\Parser();
$point = $parser->parse('POINT(174 -39.1)');

$point['value'][1] should be float but is now a string "-39.1"

The migration is available on this branch dev-doctrine3-feature

remy-theroux · 2024-04-30T06:44:05Z

Was available, seems to be on dev branch now.

Alexandre-T · 2024-04-30T06:54:37Z

Thank you, for your feedbacks @captain-igloo !

* AbstractPoint.php has ["TODO remove this line in version 5"](https://github.com/longitude-one/doctrine-spatial/blob/dev/lib/LongitudeOne/Spatial/PHP/Types/AbstractPoint.php#L149)

I created the issue #57 about AbstractPoint. My bad! :-) I will fix it tomorrow.

* Previously longitude-one/wkt-parser returned float, now returns string, eg:

$parser = new \LongitudeOne\Geo\WKT\Parser();
$point = $parser->parse('POINT(174 -39.1)');

$point['value'][1] should be float but is now a string "-39.1"

About the wkt-parser, Yes, it returns no longer float, but string. Because the doctrine/lexer only accepts string as input, I had to update the CrEOF code. And I got a lot of conversion issues when I convert it internally. Latitudes like 42.66 could become 42.67 or 42.65!!!! So, I readproof lexer and postgis manuals and the advices was to avoid float and used decimal or strings.

Why this decision... Because neither the geo-parser nor doctrine-spatial manipulates numbers. Doctrine-spatial sends these values to PostGIS or MySQL, and it is the DBMS that does the calculations and the ORM retrieves strings. IMHO, my floating-point conversions were only creating unnecessary conversion problems.

Thanks for your work on this. I have found:
* the 5.0.0.RC release still depends on doctrine/orm 2

Yes, version 5.0.0 is still compatible with doctrine/orm:^2.19. The composer.json file allows it, and unlike AbstractPoint, this is not an oversight on my part. To my surprise, my tests revealed that the code worked with both versions almost flawlessly. I applied one or two changes and the code is compatible with all versions, from 2.19 to 4.0! To ensure that this does not change over time, I have added a matrix to change the orm in the actions.

I believe that a team that wants to stay on version orm:2.19 can use version 4doctrine-spatial:4 . A team that plans to upgrade can go to 5. This allows the team not to change everything at once.

* Fix comments in #43 * Fix #57 * "declare(strict_types=1)" added. * Fix CI * Fixing comment headers

Alexandre-T · 2024-05-12T11:51:58Z

If no issues are reported, longitude-one/doctrine-spatial:5.0.0 will be release on May 15th

* Interfaces created to prepare 3.1.0 and 4.0.0 * Interfaces created to prepare 3.1.0 and 4.0.0 * Security issue in doctrine 2.8.3 * Headers updated * Removing no-more existent rule * Doctrine3 feature (#55) ## Doctrine 3 Feature * Compatibility with doctrine/orm:2.19 * Compatibility with doctrine/orm:3.1 * Compatibility tested (and currently working) with doctrine/orm:3.2.x-dev * Compatibility tested (and currently working) with doctrine/orm:4.0.x-dev * Fixing #40 * Fixing #42 * Fixing #43 * Fixing #55 ## List of commits * Composer upgrade feature (#47) * PHP-Code-sniffer upgraded * Composer upgraded (internal) * Github Actions upgraded * Using last stable version of geo-parser and wkt-parser * Using last stable version of longitude-one/wkb-parser instead of creof/wkb-parser * Upgrading to Phpunit 10 to be able to stop tests on deprecation * Fixing deprecations from geo-parser * Fixing hosts and ports * Restoring code coverage * Add pcov for code coverage * Fixing a bug * TODO check the code coverage * pcov added in PHP * Fixing directory for code coverage * Fixing directory for code coverage * PHP-CS-FIXER * Quality code steps * Deprecated method getName() removed Issue #40 fixed * Some deprecated calls removed, Deprecated File SQL Logger replaced, Unused methods removed * Ormtest split feature (#52) * Some deprecated calls removed, Deprecated File SQL Logger replaced, Unused methods removed * Logger class declared outside of OrmTestCase.php * Truncate tables before each test * Removing method * Quality code improved * Typo * Decrease OrmTestCase class complexity * Phpunit files updated * Removing 'else' expressions * Improving quality code * Test were not executed * Message fixed * Typo fixed * Class-string called without a string * MySql replaced with MySQL * All internal exceptions implements ExceptionInterface. * Fixing comment * Issue #42 fixed (#53) * test to reproduce issue added * Fixing test * Issue #42 fixed * Issue 12 (#54) * Removing travis directories and files * Creating a new composer script to create code coverage in cov format * Merging *.cov into a clover.xml file * Fixing coveralls.io * Fixing issues with doctrine/orm:3.0 * Adding "with all dependencies" option * Adding test with doctrine/orm:4.1.x-dev * Headers updated * README.md updated * Removing unused file * Code coverage improved * Issue #57 fixed (#59) * Fix comments in #43 * Fix #57 * "declare(strict_types=1)" added. * Fix CI * Fixing comment headers * Quality tools feature (#61) * Longitude-One quality tools added * Headers updated * PHP-Cs-Fixer Rules updated * Code sniffer rules updated * Ecologic feature (#63) * Ecologic feature. To avoid useless tests, the full tests are only launched when tests and quality tools are completed on stable version. * Specify return types (#56) * Return types of test methods specified * Quality-tools after merge * PHP Stan level 0 * Restore compatibility with ORM ^2.19 * Architecture updated * PHP-Stan level 2 * PHP-Stan level 3 * PHP-Stan level 4 * Fixing UnsupportedPlatform test * PHP-Stan level 5 * PHP-Stan level 6 * Fixing platform test on orm:^2.19 * PHP-Stan level 7 * PHP-Stan level 8 * PHP-Stan level 9 * Fixing warning * Issue #65 (#66) * Enhancement #65 implemented * Php-Stan check activated * Add delta because results are different between MySQL5.7 and MySQL8.0 * Return types mentioned (#67) * Return types mentioned * Unexpected file removed * Show installed libraries * Remove no-longer existing error in baseline * Remove no-longer used libraries in composer * Php-stan fix * Php-stan fix

Alexandre-T · 2024-05-15T20:38:41Z

Version 5.0.0 released : #69

captain-igloo · 2024-05-16T21:05:00Z

Further to your comment about floats changing to strings above. Now LongitudeOne\Spatial\PHP\Types\AbstractPoint::setX() and setY() take a string. Should these not take int or string?

https://github.com/longitude-one/doctrine-spatial/blob/main/lib/LongitudeOne/Spatial/PHP/Types/AbstractPoint.php#L127

Alexandre-T · 2024-05-17T07:21:08Z

Thank you for your feedback.

I edited my comment, because I was wrong. Don't hesitate to create an issue.

Yes, it should.

IMHO, the geo-parser could have a lot of issues with these unexpected conversions. I have to check it and proofread the code.

Alexandre-T added dependencies enhancement New feature or request labels Mar 31, 2024

Alexandre-T self-assigned this Mar 31, 2024

Alexandre-T pinned this issue Mar 31, 2024

This was referenced Mar 31, 2024

User Deprecated: AbstractMySQLPlatform::getName() #40

Closed

Upgrade package longitude-one/wkt-parser #48

Closed

Alexandre-T added this to the Version 5.0 - Doctrine/ORM 3.0 milestone Apr 25, 2024

Alexandre-T added the fixed-in-dev label Apr 27, 2024

Alexandre-T mentioned this issue Apr 27, 2024

Doctrine3 feature #55

Merged

Alexandre-T closed this as completed Apr 27, 2024

Alexandre-T mentioned this issue Apr 30, 2024

Hard-code the type (string) in AbstractPoint.php #57

Closed

Alexandre-T added a commit that referenced this issue May 1, 2024

Fix #43

8dda0c3

Alexandre-T added a commit that referenced this issue May 1, 2024

Fix #43

006e742

Alexandre-T added a commit that referenced this issue May 1, 2024

Issue #57 fixed (#59)

804498e

* Fix comments in #43 * Fix #57 * "declare(strict_types=1)" added. * Fix CI * Fixing comment headers

Alexandre-T modified the milestones: Version 5.0 - Doctrine/ORM 3.0, Version 5.1 May 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for doctrine/orm 3.0 #43

Add support for doctrine/orm 3.0 #43

captain-igloo commented Feb 13, 2024

Alexandre-T commented Mar 12, 2024

lukena-xxl commented Mar 13, 2024

Alexandre-T commented Mar 13, 2024 •

edited

Loading

Alexandre-T commented Mar 24, 2024

Alexandre-T commented Mar 31, 2024 •

edited

Loading

remy-theroux commented Apr 5, 2024

danielgwood commented Apr 10, 2024

Alexandre-T commented Apr 10, 2024 •

edited

Loading

Alexandre-T commented Apr 26, 2024 •

edited

Loading

remy-theroux commented Apr 29, 2024

manaka02 commented Apr 29, 2024

tiapnn commented Apr 29, 2024

Alexandre-T commented Apr 29, 2024 •

edited

Loading

captain-igloo commented Apr 29, 2024

remy-theroux commented Apr 30, 2024 •

edited

Loading

remy-theroux commented Apr 30, 2024

Alexandre-T commented Apr 30, 2024 •

edited

Loading

Alexandre-T commented May 12, 2024

Alexandre-T commented May 15, 2024 •

edited

Loading

captain-igloo commented May 16, 2024

Alexandre-T commented May 17, 2024 •

edited

Loading

Add support for doctrine/orm 3.0 #43

Add support for doctrine/orm 3.0 #43

Comments

captain-igloo commented Feb 13, 2024

Alexandre-T commented Mar 12, 2024

lukena-xxl commented Mar 13, 2024

Alexandre-T commented Mar 13, 2024 • edited Loading

Alexandre-T commented Mar 24, 2024

Alexandre-T commented Mar 31, 2024 • edited Loading

remy-theroux commented Apr 5, 2024

danielgwood commented Apr 10, 2024

Alexandre-T commented Apr 10, 2024 • edited Loading

Alexandre-T commented Apr 26, 2024 • edited Loading

Good News!

Target Release Date:

remy-theroux commented Apr 29, 2024

manaka02 commented Apr 29, 2024

tiapnn commented Apr 29, 2024

Alexandre-T commented Apr 29, 2024 • edited Loading

captain-igloo commented Apr 29, 2024

remy-theroux commented Apr 30, 2024 • edited Loading

remy-theroux commented Apr 30, 2024

Alexandre-T commented Apr 30, 2024 • edited Loading

Alexandre-T commented May 12, 2024

Alexandre-T commented May 15, 2024 • edited Loading

captain-igloo commented May 16, 2024

Alexandre-T commented May 17, 2024 • edited Loading

Alexandre-T commented Mar 13, 2024 •

edited

Loading

Alexandre-T commented Mar 31, 2024 •

edited

Loading

Alexandre-T commented Apr 10, 2024 •

edited

Loading

Alexandre-T commented Apr 26, 2024 •

edited

Loading

Alexandre-T commented Apr 29, 2024 •

edited

Loading

remy-theroux commented Apr 30, 2024 •

edited

Loading

Alexandre-T commented Apr 30, 2024 •

edited

Loading

Alexandre-T commented May 15, 2024 •

edited

Loading

Alexandre-T commented May 17, 2024 •

edited

Loading