Code

Refactor the packet generator#2070

Code

Merged

lmoureaux merged 39 commits intolongturn:masterlongturn/freeciv21:masterfrom lmoureaux:refactor/generate-packetslmoureaux/freeciv21:refactor/generate-packetsCopy head branch name to clipboardDec 10, 2023

+1,325-1,476

Commits

Commits on Dec 3, 2023

• Reformat generate_packets with black

  lmoureaux

  committed
  2312633

  Copy full SHA for 2312633

• generate_packets: replace without() with sets

  lmoureaux

  committed
  c6a90f9

  Copy full SHA for c6a90f9

• generate_packets: use argparse

  Show description for 1782bd1
  lmoureaux

  committed
  1782bd1

  Copy full SHA for 1782bd1

• generate_packets: drop mentions of old python, modernize

  lmoureaux

  committed
  9eda15e

  Copy full SHA for 9eda15e

• Fix lazy_overwrite

  lmoureaux

  committed
  88c7ac3

  Copy full SHA for 88c7ac3

• generate_packets: factor out parse_packet_definitions

  lmoureaux

  committed
  76b69e7

  Copy full SHA for 76b69e7

• generate_packets: remove unused imports

  lmoureaux

  committed
  986c294

  Copy full SHA for 986c294

• generate_packets: Remove lazy overwrite support

  Show description for e6ac27f
  lmoureaux

  committed
  e6ac27f

  Copy full SHA for e6ac27f

• generate_packets: factor out writing files

  lmoureaux

  committed
  2509400

  Copy full SHA for 2509400

• generate_packets: some C++ification

  lmoureaux

  committed
  f8c6456

  Copy full SHA for f8c6456

• generate_packets: restore indent

  lmoureaux

  committed
  4f902de

  Copy full SHA for 4f902de

• generate_packets: rename p -> packets (pylint)

  lmoureaux

  committed
  9c36037

  Copy full SHA for 9c36037

• generate_packets: modernize write_client_header

  lmoureaux

  committed
  c27163c

  Copy full SHA for c27163c

• generate_packets: modernize write_client_source

  lmoureaux

  committed
  cf9684b

  Copy full SHA for cf9684b

• generate_packets: simplify worklist support

  lmoureaux

  committed
  506e4b1

  Copy full SHA for 506e4b1

• generate_packets: modernize write_server_header

  lmoureaux

  committed
  c6104f0

  Copy full SHA for c6104f0

• generate_packets: modernize write_server_source

  lmoureaux

  committed
  d737e8e

  Copy full SHA for d737e8e

• generate_packets: longer variable names (pylint)

  lmoureaux

  committed
  ce1b409

  Copy full SHA for ce1b409

• generate_packets: don't shadow 'args' (pylint)

  lmoureaux

  committed
  5778e19

  Copy full SHA for 5778e19

• generate_packets: Type as namedtuple

  lmoureaux

  committed
  46cb2b1

  Copy full SHA for 46cb2b1

• generate_packets: start modernizing Packet constructor

  lmoureaux

  committed
  ce98f53

  Copy full SHA for ce98f53

• generate_packets: start work on get_packet_handlers_fill_capability

  lmoureaux

  committed
  cd0163e

  Copy full SHA for cd0163e

• generate_packets: refactor get_packet_handlers_fill_capability

  lmoureaux

  committed
  5b1f8fc

  Copy full SHA for 5b1f8fc

• generate_packets: refactor get_enum_packet

  lmoureaux

  committed
  e0731f9

  Copy full SHA for e0731f9

• generate_packets: add more r-strings (pylint)

  lmoureaux

  committed
  3bbd3a3

  Copy full SHA for 3bbd3a3

• generate_packets: remove __dummy fields

  Show description for f237333
  lmoureaux

  committed
  f237333

  Copy full SHA for f237333

• generate_packets: Rename prefix() to indent()

  lmoureaux

  committed
  d274625

  Copy full SHA for d274625

• generate_packets: use itertools for get_choices

  lmoureaux

  committed
  ed3a068

  Copy full SHA for ed3a068

• generate_packets: no regex in parse_fields

  lmoureaux

  committed
  66b5e44

  Copy full SHA for 66b5e44

• generate_packets: simplify how type aliases are done

  lmoureaux

  committed
  c572d5a

  Copy full SHA for c572d5a

• generate_packets: simplify parse_fields slightly

  lmoureaux

  committed
  6417768

  Copy full SHA for 6417768

• generate_packets: f-strings and cleanup

  Show description for cca3e31
  lmoureaux

  committed
  cca3e31

  Copy full SHA for cca3e31

• generate_packets: replace custom format strings

  lmoureaux

  committed
  0ad7dcb

  Copy full SHA for 0ad7dcb

• generate_packets: promote comment to help string

  lmoureaux

  committed
  41fe87e

  Copy full SHA for 41fe87e

• generate_packets: document Field attributes for pylint

  lmoureaux

  committed
  101bb9a

  Copy full SHA for 101bb9a

• Remove unused parts of dataio

  Show description for 3c0217c
  lmoureaux

  committed
  3c0217c

  Copy full SHA for 3c0217c

• Remove unused dataio "field location" stuff

  Show description for 7d298d4
  lmoureaux

  committed
  7d298d4

  Copy full SHA for 7d298d4

• generate_packets: declare for loop counters in loop

  lmoureaux

  committed
  a4bee3f

  Copy full SHA for a4bee3f

• generate_packets: misc pylint warnings

  lmoureaux

  committed
  7674728

  Copy full SHA for 7674728