Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

Meta properties allows functions #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Meta properties allows functions #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/router.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ run = (defaults = {}) ->

twitter = _.extend({}, defaults.twitter, seo.twitter)
og = _.extend({}, defaults.og, seo.og)
meta = _.extend({}, defaults.meta, seo.meta)
meta = _.extend({}, call(seo.meta or defaults.meta))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this behave in the same way as meta = _.extend({}, defaults.meta, seo.meta)? Looks like seo.meta will override everything from defaults.meta if it's present – not extending it?


inheritFromParent twitter, ['image', 'description']
inheritFromParent og, ['image', 'description']
Expand Down