Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Allowing use of proxy with http streaming #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

corinnekunze
Copy link

Hi,
We need to use streaming as well as through a proxy.

I noticed there wasn't functionality to do that but you have the ability to define proxy as a config when you initialize the LookerSDK::Client.

So I tapped into that so if a proxy variable is defined it'll try to use that with the Net::HTTP::Proxy class and chain it to the streaming request.

I've tested this in our app and it seems to be allowing the request through.

Not seeing any groundwork for testing of this StreamingClient though, that makes it difficult to write a test for this.

@dthorpe
Copy link
Contributor

dthorpe commented Sep 17, 2018

Hi Corrine,

Great! Thanks for looking into this and submitting the PR. I'll get someone to check this out shortly.

-Danny

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants