Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error catching/logging for recording start and stop/upload problems #402

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Add error catching/logging for recording start and stop/upload problems #402

wants to merge 19 commits into from

Commits on Jul 15, 2024

  1. add video id to every event when using video-record mixin

    @becky-gilbert
    becky-gilbert committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    ef861de View commit details
    Browse the repository at this point in the history

  2. add session video id to all events that session recording is in progr… 

    …ess, and to specific set-up/stop events
    @becky-gilbert
    becky-gilbert committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    030bd62 View commit details
    Browse the repository at this point in the history

  3. update comments/docs about video/session recording events

    @becky-gilbert
    becky-gilbert committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    cc826ef View commit details
    Browse the repository at this point in the history

  4. add comment about error handling

    @becky-gilbert
    becky-gilbert committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    fbf44b4 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. add stopping flag and event logs for upload success/timeout/failed, i… 

    …mprove errors for Sentry logging
    @becky-gilbert
    becky-gilbert committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    31170ff View commit details
    Browse the repository at this point in the history

  2. add error catching and upload/timeout/error event logs for recording … 

    …start/stop, improve errors for Sentry logging
    @becky-gilbert
    becky-gilbert committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    12f6280 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. if the study ends early via the confirmation dialog, then stop/upload… 

    … any in-progress video recordings
    @becky-gilbert
    becky-gilbert committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ed60839 View commit details
    Browse the repository at this point in the history

  2. switch completeUpload to promise chain instead of mixing with async/a… 

    …wait, add upload part promises to chain to catch errors
    @becky-gilbert
    becky-gilbert committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    84164fe View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. switch record from async/await to promise then/catch; put createUploa… 

    …d in promise chain and catch/log all errors
    @becky-gilbert
    becky-gilbert committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b4b161b View commit details
    Browse the repository at this point in the history

  2. only provide a stream time if recording is in progress, otherwise null

    @becky-gilbert
    becky-gilbert committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a309ff1 View commit details
    Browse the repository at this point in the history

  3. throw new Error rather than string

    @becky-gilbert
    becky-gilbert committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5848624 View commit details
    Browse the repository at this point in the history

  4. switch stop to promise then/catch instead of mixing with async/await … 

    …to help with error logging; remove unnecessary _stopPromise
    @becky-gilbert
    becky-gilbert committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c707b5b View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. merge develop and fix conflicts

    @becky-gilbert
    becky-gilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    49ca161 View commit details
    Browse the repository at this point in the history

  2. fix incorrect function name: onUploadDone

    @becky-gilbert
    becky-gilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1f7dd89 View commit details
    Browse the repository at this point in the history

  3. remove console logs

    @becky-gilbert
    becky-gilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cc64ff3 View commit details
    Browse the repository at this point in the history

  4. fix check for upload timeout in stop recorder catch blocks

    @becky-gilbert
    becky-gilbert committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    79a52c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. throw error in catch block for starting trial recording

    @becky-gilbert
    becky-gilbert committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a6bb2db View commit details
    Browse the repository at this point in the history

  2. add catch block for starting sesssion recorder, add event log and thr… 

    …ow error
    @becky-gilbert
    becky-gilbert committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f94ec89 View commit details
    Browse the repository at this point in the history

  3. save error object message to data (not actual object)

    @becky-gilbert
    becky-gilbert committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ea21951 View commit details
    Browse the repository at this point in the history