Modifying Init Containers #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Shall we go ahead and try out a new deployment on staging with it? |
|
Yes, please. I'll verify the errors don't show up after the deployment. |
|
ok, new build of lookit-api using this orchestrator build happening now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull changes the init containers used to wait for both Cloud SQL Proxy and RabbitMQ to start up on the cluster. The previous implementation utilized the kubectl deploy command which does not guarantee service availability.
The SQL Proxy init container now uses pg_isready to confirm when the database connection is ready. The RabbitMQ init container now uses netcat to wait until RabbitMQ is responding on port 5672.
Resolves: #5 & #6