[WIP] Add bindings for Karma proto #203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
changed the title
enlight
requested changes
Jan 21, 2019
|
|
||
| export class Karma extends Contract { | ||
| static async createAsync(client: Client, callerAddr: Address): Promise<DPOS> { | ||
| const contractAddr = await client.getContractAddressAsync('dpos') |
| } | ||
|
|
||
| async depositCoinAsync(amount: BN, from: Address): Promise<void> { | ||
| const karmaUserAmountReq = new KarmaUserAmount() |
There was a problem hiding this comment.
KarmaUserAmount gah. nvm. I'll fix it later.
|
|
||
| async getUserKarmaAsync(user: Address, target: KarmaSourceTarget): Promise<KarmaTotal> { | ||
| const karmaUserTargetReq = new KarmaUserTarget() | ||
| let response: any |
There was a problem hiding this comment.
This should be a protobuf instance?
There was a problem hiding this comment.
Yeah, I wanna add a new proto response and wrap it inside, as we do in other places, but the current karma implementation returns the data directly.
| } | ||
|
|
||
| async getSourcesAsync(user: Address): Promise<KarmaSources> { | ||
| let response: any |
There was a problem hiding this comment.
This should be a protobuf instance?
| } | ||
|
|
||
| async getUserStateAsync(user: Address): Promise<KarmaState> { | ||
| let response: any |
There was a problem hiding this comment.
This should be a protobuf instance?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto bindings from loomnetwork/go-loom#190
Karma contract bindings from loomnetwork/loomchain#466
Closes #197