[DO-NOT-MERGE] Better loom compatibility with JSON RPC specification for Ethereum #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
* Better docs on loom provider responses * Improved interfaces on loom provider * Do not throw when cant find getCode * Improving block 0 handling * Added strict mode that remove non standard variables
eduardonunesp
force-pushed
the
improving-loom-provider-compatibilities
branch
from
ae913e4 to
99219e8
Compare
eduardonunesp
changed the title
eduardonunesp
changed the title
enlight
reviewed
Mar 26, 2019
src/loom-provider.ts
Outdated
| @@ -832,17 +987,28 @@ export class LoomProvider { | |||
| } | |||
|
|
|||
| private _createLogResult(log: EthFilterLog): IEthFilterLog { | |||
| const removed = log.getRemoved() | |||
| const blockTime = numberToHexLC(log.getBlockTime()) | |||
There was a problem hiding this comment.
Looks like this was a decimal before, won't converting to hex break clients?
There was a problem hiding this comment.
Fixed, the potential break can exist only if the client marks as strict like loomProvider.strict = true
| blockNumber: string | ||
| transactionHash: string | ||
| number: string | null | ||
| hash: string |
There was a problem hiding this comment.
Potentially breaking changes?
There was a problem hiding this comment.
Those are the values according to the specification, added back the non-strict values at the end of the interface
There was a problem hiding this comment.
Fixed, the potential break can exist only if the client marks as strict like loomProvider.strict = true
eduardonunesp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets to improve the LoomProvider compatibility with Web3 and Block Explorers that understanding Eth JSON RPC