Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Receipts Code #1489

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Conversation

pathornteng
Copy link
Contributor

@pathornteng pathornteng commented Sep 18, 2019

This PR has refactored the receipts code as follow

  1. Remove LevelDBReceipt, moving most of the logic to evmAuxStore
  2. Auto-rename receipts_db to evmaux.db when starting the node
  3. Use TM goleveldb instead of syndtr/goleveldb
  4. Since TM goleveldb does not have transaction feature, we have to Implement atomic KV store for evmauxstore for commiting receipts
  5. Deprecate EVMPersistentTxReceiptsMax and change it to EvmAuxStore.MaxReceipts
  6. if EvmAuxStore.MaxReceipts is set to 0, no receipts are persisted in evmaux.db

Ref: #1486

Note: we probably need to fix this before we merge this PR so that we don't have to save TxHashList to EvmAuxStore anymore.

  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

@pathornteng pathornteng changed the title Add option to store evmaux in memory [WIP] Refactor Receipts Code Sep 19, 2019
@pathornteng pathornteng changed the title [WIP] Refactor Receipts Code Refactor Receipts Code Sep 30, 2019
@pathornteng pathornteng changed the title Refactor Receipts Code [DO NOT MERGE] Refactor Receipts Code Oct 1, 2019
@pathornteng pathornteng changed the title [DO NOT MERGE] Refactor Receipts Code Refactor Receipts Code Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants