-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Receipts Code #1489
Open
pathornteng
wants to merge
34
commits into
master
Choose a base branch
from
option-to-disable-evmaux-db
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor Receipts Code #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enlight
requested changes
Sep 23, 2019
enlight
requested changes
Sep 30, 2019
enlight
requested changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has refactored the receipts code as follow
LevelDBReceipt
, moving most of the logic toevmAuxStore
receipts_db
toevmaux.db
when starting the nodegoleveldb
instead ofsyndtr/goleveldb
goleveldb
does not have transaction feature, we have to Implement atomic KV store for evmauxstore for commiting receiptsEVMPersistentTxReceiptsMax
and change it toEvmAuxStore.MaxReceipts
EvmAuxStore.MaxReceipts
is set to 0, no receipts are persisted inevmaux.db
Ref: #1486
Note: we probably need to fix this before we merge this PR so that we don't have to save TxHashList to EvmAuxStore anymore.