Impliments debug_traceTransaction

app.go

@@ -718,7 +718,6 @@ func (a *Application) DeliverTx(txBytes []byte) abci.ResponseDeliverTx {
 	if a.EVMTracer != nil {
 		log.Debug("evm trace", "trace", a.EVMTracer)
 	}
-
 	txFailed = r.Code != abci.CodeTypeOK
 	// TODO: this isn't 100% reliable when txFailed == true
 	isEvmTx = r.Info == utils.CallEVM || r.Info == utils.DeployEvm
@@ -954,7 +953,7 @@ func (a *Application) ReplayApplication(blockNumber uint64, blockstore store.Blo
 		return nil, 0, errors.Errorf("no saved version for height %d", blockNumber)
 	}
 
-	splitStore := store.NewSplitStore(snapshot, store.NewMemStore(), startVersion-1)
+	splitStore := store.NewSplitStore(snapshot, startVersion-1)
 	factory := a.TxHandlerFactory.Copy(splitStore)
 	txHandle, err := factory.TxHandlerWithTracerAndDefaultVmManager(nil, false)
 	if err != nil {

config/config.go

@@ -145,7 +145,7 @@ type Config struct {
 	AllowNamedEvmContracts bool
 
 	// Dragons
-	EVMTracer *EVMTracer
+	EVMTracer *EVMTracerConfig
 	// Set to true to disable minimum required build number check on node startup
 	SkipMinBuildCheck bool
 
@@ -172,7 +172,7 @@ func DefaultFnConsensusConfig() *FnConsensusConfig {
 	}
 }
 
-type EVMTracer struct {
+type EVMTracerConfig struct {
 	Enabled        bool   // enable tracer
 	Tracer         string // enable JavaScript-based transaction tracing
 	DisableMemory  bool   // disable memory capture
@@ -181,8 +181,8 @@ type EVMTracer struct {
 	Limit          int    // maximum length of output, but zero means unlimited
 }
 
-func DefaultEvmTraceConfig() *EVMTracer {
-	return &EVMTracer{
+func DefaultEvmTraceConfig() *EVMTracerConfig {
+	return &EVMTracerConfig{
 		Enabled: false,
 	}
 }

rpc/debug/trace.go

@@ -150,6 +150,9 @@ func runTxsTo(app *loomchain.Application, blockstore store.BlockStore, startHeig
 		}
 
 		_ = app.EndBlock(requestEndBlock(h))
+
+		// todo we should really be matching the app hash returned here with the one that was
+		// stored in the next block, otherwise we can't really know if the replay was successful or not.
 		_ = app.Commit()
 	}
 	return nil, errors.Errorf("cannot find transaction at height %d index %d", height, index)

store/splitstore.go

@@ -1,6 +1,9 @@
 package store
 
 import (
+	"bytes"
+	"sort"
+
 	"github.com/loomnetwork/go-loom/plugin"
 )
 
@@ -11,10 +14,10 @@ type splitStore struct {
 	version int64
 }
 
-func NewSplitStore(full KVReader, empty VersionedKVStore, version int64) VersionedKVStore {
+func NewSplitStore(history KVReader, version int64) VersionedKVStore {
 	return &splitStore{
-		KVReader:         full,
-		VersionedKVStore: empty,
+		KVReader:         history,
+		VersionedKVStore: NewMemStore(),
 		deleted:          make(map[string]bool),
 		version:          version,
 	}
@@ -33,6 +36,12 @@ func (ss *splitStore) Get(key []byte) []byte {
 func (ss *splitStore) Range(prefix []byte) plugin.RangeData {
 	readerRange := ss.KVReader.Range(prefix)
 	updateRange := ss.VersionedKVStore.Range(prefix)
+
+	// VersionedKVStore comes from a MemStore, hence updateRange is not deterministic
+	sort.Slice(updateRange, func(i, j int) bool {
+		return bytes.Compare(updateRange[i].Key, updateRange[j].Key) < 0
+	})
+
 	for _, re := range readerRange {
 		if !ss.VersionedKVStore.Has(re.Key) && !ss.deleted[string(re.Key)] {
 			updateRange = append(updateRange, re)

store/store_test.go

@@ -450,7 +450,7 @@ type SplitStoreTestSuite struct {
 
 // runs before each test in this suite
 func (ts *SplitStoreTestSuite) SetupTest() {
-	ts.store = NewSplitStore(NewMemStore(), NewMemStore(), 1)
+	ts.store = NewSplitStore(NewMemStore(), 1)
 }
 
 func (ts *SplitStoreTestSuite) SetupSuite() {