New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add memoization to agree type system #20

Open

tlogan wants to merge 1 commit into master from speed_up_ui_ats

Contributor

tlogan commented Mar 22, 2020

I've made a few changes to increase the responsiveness of the eclipse UI.

memoize agree type inference
change type checking to be triggered on saves (NORMAL setting)
remove unnecessary scoping computation.

Things to double check:

There isn't any use of stale memoized results.
The removed code is actually unnecessary.


          add memoization to agree type system

256e8a1

remove extra scoping methods
change type check to normal (check on save)

tlogan requested review from ericmercer, kfhoech and iamundson

March 22, 2020 16:00

Contributor Author

tlogan commented Apr 2, 2020

Changes suggested by Karl:

undo changes to package version numbers in manifest files.
change AGREE validation type check to EXPENSIVE mode.
create parallel validation methods with FAST mode that checks a new menu setting either calls the EXPENSIVE method or not.
modify infer method in AgreeTypeSystem to memoize or not based on a new menu setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet