chore: disable GreenKeeper #3014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
added
the
Internal Tooling
jannyHou
approved these changes
May 31, 2019
nabdelgadir
reviewed
May 31, 2019
There was a problem hiding this comment.
+1 to @jannyHou's comment and should https://github.com/strongloop/loopback-next/blob/master/package.json#L80-L99 also be removed?
|
@jannyHou @nabdelgadir good catch! I search for other possible occurences of the term "greenkeeper" and founds few more places to change - see 63773cb LGTY now? |
Done. |
cool LGTM
raymondfeng
approved these changes
May 31, 2019
Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
disable-greenkeeper
branch
from
63773cb to
fa264cc
Compare
b-admike
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreenKeeper does not support lerna monorepos using package-locks, see greenkeeperio/greenkeeper#1080. Let's migrate to RenovateBot, which we are already successfully using in loopback4-example-shopping.
This pull request is removing GreenKeeper configuration, scripts and documentation.
Before we land this pull request, we should probably remove GreenKeeper from GitHub applications, e.g. here: https://github.com/organizations/strongloop/settings/installations/633361