Make `SmartImageTask.OnCompleteHandler` an abstract class #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

codeguru42 wants to merge 1 commit into loopj:master from codeguru42:abstract-class

codeguru42 commented Mar 3, 2014

Do you intend users to extend OnCompleteHandler? If so, it is safer to mark onComplete() and the class itself as abstract.


          Make SmartImageTask.OnCompleteHandler an abstract class

519801d

faip520 commented Mar 3, 2014

I may say that this repo hasn't been updated for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet