feat: sync UI with lottie.github.io #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
The table of contents is missing sub-items in the new style
|
|
The arrow in sub-menus isn't very visible, also sub-menus require a click to open, they should just open on hover
|
|
This page has metadata to hide the TOC but it's still being rendered
|
mbasaglia
requested changes
Jan 30, 2024
.github/workflows/pages.yml
Outdated
Comment on lines
5
to
6
| # - main | ||
| - mf/ui-updates |
There was a problem hiding this comment.
This should go back to main before merging
Aidosmf
force-pushed
the
mf/ui-updates
branch
from
6e8182d to
12a334f
Compare
|
@mbasaglia thanks for the review. I brought back the cinder theme with the new stylings and I have applied all the suggestions. |
Does the CSS stuff still work fine with it? |
I adjusted css and tested it, seems fine, unless you'd find anything |
mbasaglia
approved these changes
Jan 30, 2024
b-wils
approved these changes
Jan 30, 2024
kudanai
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lottiefiles.github.io/lottie-spec/