Initial wording for shape rendering #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This SHOULD match lottie-web output. |
b-wils
approved these changes
Feb 7, 2024
fmalita
requested changes
Feb 9, 2024
|
As a sanity check, I've written this script that given rendering instructions as per the specs, renders a lottie path shape: https://gist.github.com/mbasaglia/5e82cbbe64bbbd3ce96aadb0f952b1e9 Perhaps it would be useful to add it to the github actions to verify the instructions make sense and such but it would need more work for that. |
|
Shapes as rendered from the instructions: |
fmalita
approved these changes
Feb 12, 2024
kudanai
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wording for shape algorithms. I used BCP 14 words to specify compliance requirements.