Fix html loading and add changelog

lotusprey · May 7, 2024 · 78f84d3 · 78f84d3
1 parent 8ccdb3f
commit 78f84d3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 24 deletions.
diff --git a/fastlane/metadata/android/en-US/changelogs/67.txt b/fastlane/metadata/android/en-US/changelogs/67.txt
@@ -0,0 +1,10 @@
+- AniList Markdown is supported almost fully
+- AniList links in markdown text are opened within the app
+- More markdown quick access buttons in the composition sheet
+- Collection previews can be filtered like full collections
+- User/Discover reviews can be filtered by media type
+- You can long-press to copy a media description
+- Redesigned media overview tab and other elements
+- Fixed bugs around deep link opening
+- Image popups are also cached
+- Other fixes and improvements
diff --git a/lib/common/widgets/html_content.dart b/lib/common/widgets/html_content.dart
@@ -38,14 +38,20 @@ class HtmlContent extends StatelessWidget {
         if (source != null) showPopUp(context, ImageDialog(source));
       },
       factoryBuilder: () => _CustomWidgetFactory(),
-      onLoadingBuilder: (_, __, ___) => renderMode != RenderMode.sliverList
-          ? const Center(child: Loader())
-          : const SliverToBoxAdapter(child: Center(child: Loader())),
-      onErrorBuilder: (_, element, err) => renderMode != RenderMode.sliverList
-          ? _errorBuilder(context, element.localName, err)
-          : SliverToBoxAdapter(
-              child: _errorBuilder(context, element.localName, err),
+      onLoadingBuilder: (_, __, ___) => const Center(child: Loader()),
+      onErrorBuilder: (_, element, err) => Center(
+        child: IconButton(
+          tooltip: 'Error',
+          icon: const Icon(Icons.close_outlined),
+          onPressed: () => showPopUp(
+            context,
+            ConfirmationDialog(
+              title: 'Failed to load element ${element.localName}',
+              content: err.toString(),
             ),
+          ),
+        ),
+      ),
       customStylesBuilder: (element) {
         return switch (element.localName) {
           'br' => const {'line-height': '15px'},
@@ -128,23 +134,6 @@ class HtmlContent extends StatelessWidget {
       },
     );
   }
-
-  Widget _errorBuilder(
-    BuildContext context,
-    String? elementName,
-    dynamic err,
-  ) =>
-      IconButton(
-        tooltip: 'Error',
-        icon: const Icon(Icons.close_outlined),
-        onPressed: () => showPopUp(
-          context,
-          ConfirmationDialog(
-            title: 'Failed to load element $elementName',
-            content: err.toString(),
-          ),
-        ),
-      );
 }
 
 final _routeMatchers = {