Formal BBox struct #377
Formal BBox struct #377
Conversation
benjamin051000
force-pushed
the
formalize-bbox
branch
3 times, most recently
from
fabd9d0 to
4e65ed6
Compare
benjamin051000
force-pushed
the
formalize-bbox
branch
2 times, most recently
from
0faf517 to
aa7a51d
Compare
|
Blocked on #378 |
|
Okay, on my local machine, I've definitely swapped a lat/lng somewhere... because renders are no longer working :( I'll try to figure out which |
benjamin051000
force-pushed
the
formalize-bbox
branch
from
aa7a51d to
4776f60
Compare
| pub fn from_str(s: &str) -> Result<Self, String> { | ||
| let [min_lat, min_lng, max_lat, max_lng]: [f64; 4] = s | ||
| .split(',') | ||
| .map(|e| e.parse().unwrap()) |
There was a problem hiding this comment.
Should this return an Err signifying parsing failure?
| .map(|e| e.parse().unwrap()) | ||
| .collect::<Vec<_>>() | ||
| .try_into() | ||
| .unwrap(); |
There was a problem hiding this comment.
Should this return an Err? What cases will the try_into fail?
benjamin051000
force-pushed
the
formalize-bbox
branch
from
4776f60 to
a6310f5
Compare
| fn reorder_bbox(bbox: &[f64]) -> (f64, f64, f64, f64) { | ||
| (bbox[1], bbox[0], bbox[3], bbox[2]) | ||
| } |
There was a problem hiding this comment.
hm, do I still need to do this? Maybe we can just make the GUI return it in the right order in the first place...
benjamin051000
force-pushed
the
formalize-bbox
branch
from
a6310f5 to
ad642c9
Compare
src/retrieve_data.rs
Outdated
| bbox.1, bbox.0, bbox.3, bbox.2 | ||
| bbox.min().lng, | ||
| bbox.min().lat, | ||
| bbox.max().lng, | ||
| bbox.max().lat |
There was a problem hiding this comment.
It's gotta be this that's causing the issue.
There was a problem hiding this comment.
Okay, I might be wrong, because when I switch these around, the API doesn't return any data. I guess I'm stumped as to why this no longer works.
There was a problem hiding this comment.
It's rendering the grass, but nothing on top of it.
`BBox` represents a *valid* bounding box. It's only possible to have a BBox object that's valid.
benjamin051000
force-pushed
the
formalize-bbox
branch
from
ad642c9 to
c4a0f11
Compare
We need a more standardized way to represent bounding boxes, as we kind of just throw the string around and parse it into the four corresponding values when we need to.
Fixes #375
To Do