Fix GetPosition's interpolation to properly handle the angular part. Fixes #331 #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninnghazad
changed the title
|
Hm, i guess it is to be expected for the tests to fail now.
|
|
Added a new test for that case, however i had to adjust some of the magic numbers - and there seem to be a lot others left for fixed formats and different compiler options. Not sure how to produce all of these even. |
|
Apparently clang can't constexpr floor. So there's that also. |
louis-langholtz
added
the
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#331
Angles weren't properly interpolated, allowing for weird behavior when interpolating close to +PI / -PI.