Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for v1.5.5 release #163

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Clean up for v1.5.5 release #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f40a921
Finalizing for v1.5.5 release
technosf Nov 8, 2024
e0072a7
Removed debug messages for release
technosf Nov 11, 2024
c772b2e
Merge branch 'louis77:development' into development
technosf Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions data/com.github.louis77.tuner.appdata.xml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,16 @@
</provides>

<releases>
<release version="1.5.5" date="2024-10-31">
<release version="1.5.5" date="2024-11-08">
<description>
<p>Maintanance release:</p>
<ul>
<li>Updated HTTP Session connections to improve response</li>
<li>Increased Search re-fire interval to reduce number of searches</li>
<li>Made Search asynchronouls so UI remains responsive during long searches</li>
<li>Add system-bus to manifest sockets</li>
<li>Updated HTTP Session params to improve response</li>
<li>Increased Search re-fire interval to reduce number of concurrent searches</li>
<li>Made Search asynchronous so UI remains responsive during searches</li>
<li>Ignore request to load failing favicons URLs</li>
<li>Removed shadow from.svg images per Flathub quality directives</li>
<li>Removed org.gnome.SettingsDaemon.MediaKeys from manifest per flathub</li>
</ul>
</description>
</release>
Expand Down
17 changes: 0 additions & 17 deletions meson/post_install.py
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/Controllers/DirectoryController.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ public class Tuner.DirectoryController : Object {
var tags = provider.get_tags ();
tags_updated (tags);
} catch (RadioBrowser.DataError e) {
warning (@"unable to load tags: $(e.message)");
warning (@"Load tags failed with error: $(e.message)");
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/Models/StationStore.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public class StationStore : Object {
parser.load_from_stream (stream);
stream.close ();
} catch (Error e) {
warning (@"store: unable to load data, does it exist? $(e.message)");
warning (@"Load failed with error: $(e.message)");
}

Json.Node? node = parser.get_root ();
Expand Down Expand Up @@ -105,7 +105,7 @@ public class StationStore : Object {
s.flush ();
s.close (); // closes base stream also
} catch (Error e) {
warning (@"store: unable to persist store: $(e.message)");
warning (@"Persist failed with error: $(e.message)");
}
}

Expand Down
6 changes: 3 additions & 3 deletions src/Services/RadioBrowser.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ namespace Tuner.RadioBrowser {
var stations = jarray_to_stations (rootarray);
return stations;
} catch (GLib.Error e) {
warning (@"Unknown error: $(e.message)");
warning (@"Error retrieving stations: $(e.message)");
}

return new ArrayList<Station>();
Expand Down Expand Up @@ -421,7 +421,7 @@ namespace Tuner.RadioBrowser {
results.add(target.get_hostname());
}
} catch (GLib.Error e) {
@warning(@"Unable to resolve SRV records: $(e.message)");
@warning(@"Unable to resolve Radio-Browser SRV records: $(e.message)");
}

if (results.is_empty)
Expand Down Expand Up @@ -463,7 +463,7 @@ namespace Tuner.RadioBrowser {
}
}
} catch (Error e) {
warning("Failed to parse API ServersJSON: $(e.message)");
warning("Failed to parse APIs JSON response: $(e.message)");
}
}

Expand Down
20 changes: 10 additions & 10 deletions src/Widgets/Window.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,14 @@ public class Tuner.Window : Gtk.ApplicationWindow {
adjust_theme(); // TODO Theme management needs research in flatpak as nonfunctional
settings.changed.connect( (key) => {
if (key == "theme-mode") {
warning("theme-mode changed");
debug("theme-mode changed");
adjust_theme();
}
});

var granite_settings = Granite.Settings.get_default ();
granite_settings.notify.connect( (key) => {
warning("theme-mode changed");
debug("theme-mode changed");
adjust_theme();
});

Expand Down Expand Up @@ -330,9 +330,9 @@ public class Tuner.Window : Gtk.ApplicationWindow {

// Auto-play
if (settings.get_boolean("auto-play")) {
warning (@"Auto-play enabled");
debug (@"Auto-play enabled");
var last_played_station = settings.get_string("last-played-station");
warning (@"Last played station is: $last_played_station");
debug (@"Last played station is: $last_played_station");

var source = _directory.load_station_uuid (last_played_station);

Expand Down Expand Up @@ -496,11 +496,11 @@ public class Tuner.Window : Gtk.ApplicationWindow {
* @param station The selected station.
*/
public void handle_station_click (Tuner.Model.Station station) {
info (@"handle station click for $(station.title)");
debug (@"handle station click for $(station.title)");
_directory.count_station_click (station);
player.station = station;

warning (@"storing last played station: $(station.id)");
debug (@"Storing last played station: $(station.id)");
settings.set_string("last-played-station", station.id);

set_title (WINDOW_NAME+": "+station.title);
Expand Down Expand Up @@ -596,17 +596,17 @@ public class Tuner.Window : Gtk.ApplicationWindow {
*/
private async void load_search_stations(string searchText, ContentBox contentBox) {

warning(@"Searching for: $(searchText)"); // FIXME warnings to debugs
debug(@"Searching for: $(searchText)"); // FIXME warnings to debugs
var station_source = _directory.load_search_stations(searchText, 100);
warning(@"Search done");
debug(@"Search done");

try {
var stations = station_source.next();
warning(@"Search Next done");
debug(@"Search Next done");
if (stations == null || stations.size == 0) {
contentBox.show_nothing_found();
} else {
warning(@"Search found $(stations.size) stations");
debug(@"Search found $(stations.size) stations");
var _slist = new StationList.with_stations(stations);
_slist.selection_changed.connect(handle_station_click);
_slist.favourites_changed.connect(handle_favourites_changed);
Expand Down