-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[slack] allow the user to choose the message format to send #5167
[slack] allow the user to choose the message format to send #5167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, mostly mergable.
I have noted one thing regarding translation keys below.
@CommanderStorm To be sure: is any more action required from me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the enhancement to the notification provider! 🎉
I have changed this to v2.0, as this is more of a feature than a bugfix.
Note
This PR is part of the v2.0
merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^
All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval
Rich messages are not functioning on version 2.0 beta. I don't receive any notifications if I enable rich messages in Slack notifications. |
This is fixed in #5196 (comment) |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #3226
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Non-richt text message:
Rich text message: