Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slack] allow the user to choose the message format to send #5167

Merged

Conversation

DaanMeijer
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3226

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Non-richt text message:
image

Rich text message:
image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, mostly mergable.
I have noted one thing regarding translation keys below.

src/components/notifications/Slack.vue Show resolved Hide resolved
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable labels Oct 8, 2024
@CommanderStorm CommanderStorm changed the base branch from 1.23.X to master October 8, 2024 09:53
@DaanMeijer
Copy link
Contributor Author

@CommanderStorm To be sure: is any more action required from me?

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement to the notification provider! 🎉
I have changed this to v2.0, as this is more of a feature than a bugfix.

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 59e70cb into louislam:master Oct 8, 2024
13 of 18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 8, 2024
@pelligrag
Copy link

Rich messages are not functioning on version 2.0 beta. I don't receive any notifications if I enable rich messages in Slack notifications.

@DaanMeijer
Copy link
Contributor Author

Rich messages are not functioning on version 2.0 beta. I don't receive any notifications if I enable rich messages in Slack notifications.

This is fixed in #5196 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[slack] Remove previews
4 participants