Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PVIReturnCodeText uncaught error if unknown error code #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sclaiborne
Copy link
Member

@sclaiborne sclaiborne commented Apr 30, 2024

What:

Uses the dict's get so if unknown error code we do not cause an exception. In the case the key does not exist None will be returned instead of an exception.

Why:

This will prevent ASPython throwing an exception

@sclaiborne sclaiborne added the bug Something isn't working label Apr 30, 2024
@sclaiborne sclaiborne requested a review from AndrewMusser April 30, 2024 21:10
@sclaiborne sclaiborne requested review from Joshpolansky and removed request for AndrewMusser September 11, 2024 21:01
@sclaiborne sclaiborne changed the title Fix PVIReturnCodeText erroring if unknown error code Fix PVIReturnCodeText uncaught error if unknown error code Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant