Implement more use cases for page select #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclaiborne
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Just a couple of questions:
- Would you recommend the use of 'PageSelect' going forward or is that now their to support backwards compatibility?
- Is there some documentation? I am coming into tmplit fairly green. If there is some documentation I might be a good candidate to provide feedback on documentation and API clarity
| {{#tmplit 'MultiSelect' maxColumns=10 data-var-name="tmplitTest:tmplit.MultiSelect_INT" data-var-name-field="tmplitTest:tmplit.MultiSelect_STRING"}} | ||
| {{#tmplit 'MultiSelect' maxColumns=11 data-var-name="tmplitTest:tmplit.MultiSelect_INT" data-var-name-field="tmplitTest:tmplit.MultiSelect_STRING"}} |
There was a problem hiding this comment.
In this case it's the number of buttons in a column before wrapping
I think you could still use PageSelect still, but it will do smarter things in the background. I think in most cases someone would want to use a specific one based on what they are putting the page select in.
Here are the docs for this. Looks like it doesn't include context yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates new tmplits for page select that aren't the default li a used inside a nav.
It also changes the current tmplit to a smarter one to decide which to used based on what the user supplies. By default, the behavior of old applications should be the same.