Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: ensure Jimp uses bicubic as the resizing kernel #3745

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Tests: ensure Jimp uses bicubic as the resizing kernel #3745

merged 1 commit into from
Jul 30, 2023

Conversation

kleisauke
Copy link
Contributor

Otherwise it'll default to bilinear (jimp.RESIZE_BILINEAR), which is faster than bicubic but less accurate.

This corresponds to what is done in the JPEG benchmark suite:

sharp/test/bench/perf.js

Line 59 in 0bc79cd

.resize(width, height, jimp.RESIZE_BICUBIC)

sharp/test/bench/perf.js

Line 79 in 0bc79cd

.resize(width, height, jimp.RESIZE_BICUBIC)

@lovell lovell merged commit bc8f983 into lovell:main Jul 30, 2023
17 checks passed
@lovell
Copy link
Owner

lovell commented Jul 30, 2023

...and thank you.

@kleisauke kleisauke deleted the bench-jimp-bicubic branch July 31, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kleisauke @lovell