Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance recombination algorithm to support 4x4 matrices (#4145) #4147

Closed
wants to merge 2 commits into from

Conversation

ton11797
Copy link
Contributor

@ton11797 ton11797 commented Jul 2, 2024

This pull request enhances the recombination algorithm to support 4x4 matrices.

Changes:

  • Modified the recombination function to handle 4x4 matrices.
  • Added test cases to verify the correctness of the implementation for 4x4 matrices.

Related Issues:

This is my first contribution to public project, so any feedback or suggestions for improvement would be greatly appreciated.

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thank you very much for working on this, I've left a couple of questions inline.

src/pipeline.cc Outdated Show resolved Hide resolved
lib/operation.js Outdated Show resolved Hide resolved
lib/index.d.ts Show resolved Hide resolved
@lovell
Copy link
Owner

lovell commented Jul 5, 2024

Thanks again for adding this feature, I made a couple of small changes and it's now on the main branch as commit 60c5c50 for inclusion in the v0.33.5 release.

@lovell lovell closed this Jul 5, 2024
@lovell lovell added this to the v0.33.5 milestone Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants