Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose input PNG comments in metadata #4157

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

nkeynes
Copy link
Contributor

@nkeynes nkeynes commented Jul 12, 2024

Read-side implementation of PNG text following the proposed API in #3549, ie

comments: [
  { keyword: 'parameters', text: 'highly detailed...' },
  { keyword: 'Copyright', text: 'legal minefield' },
  ...
]

Notes:

  • Returns the comments in the order that they're stored in the VipsImage metadata, rather than sorting on the embedded index. It looks like this should give the same ordering under normal circumstances.
  • Reuses the existing test fixture testJoinChannel.png that happens to already have a comment, in order to keep change size down.

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thank you very much for this PR, I've left a couple of questions inline.

The failing CI jobs are unrelated to this change. It looks like the latest version of node-gyp no longer supports EOL versions of Python, and the failing environments are all using either 3.6 or 3.7 (latest is 3.12). I'll investigate this separately.

src/metadata.cc Outdated Show resolved Hide resolved
src/metadata.cc Outdated Show resolved Hide resolved
@lovell
Copy link
Owner

lovell commented Jul 17, 2024

Thank you for the updates, please can you rebase against the latest commit on main to pick up the CI fixes.

@nkeynes nkeynes force-pushed the nkeynes/read-png-comments branch from ca5297d to 4f4d31d Compare July 17, 2024 09:16
@hugh-bita
Copy link

look good to me ?

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lovell lovell merged commit d642108 into lovell:main Jul 18, 2024
15 checks passed
@lovell lovell added this to the v0.33.5 milestone Jul 18, 2024
lovell added a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants