-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose input PNG comments in metadata #4157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, thank you very much for this PR, I've left a couple of questions inline.
The failing CI jobs are unrelated to this change. It looks like the latest version of node-gyp
no longer supports EOL versions of Python, and the failing environments are all using either 3.6 or 3.7 (latest is 3.12). I'll investigate this separately.
Thank you for the updates, please can you rebase against the latest commit on |
ca5297d
to
4f4d31d
Compare
look good to me ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Read-side implementation of PNG text following the proposed API in #3549, ie
Notes:
testJoinChannel.png
that happens to already have a comment, in order to keep change size down.