[ot] hw/opentitan: fix several issues with SPI Device implementation #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed as a NamedTuple Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…58a706da3 Address `TypeError: unhashable type: 'bytearray'` error message. Signed-off-by: Emmanuel Blot <[email protected]>
…on and retry count Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…exit `validate` early-terminate QEMU execution when a string/pattern is matched. Signed-off-by: Emmanuel Blot <[email protected]>
…hen requested. The power down command is not supported by the regular BootROM Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
…ral port value Signed-off-by: Emmanuel Blot <[email protected]>
…n hard-coded value Signed-off-by: Emmanuel Blot <[email protected]>
…state Signed-off-by: Emmanuel Blot <[email protected]>
Despite the command opcodes being defined in the RTL code, there are never used. What only matters is the index in the matching command info register. Moreover, the CMD_INFO.VALID bit must be enforced for all commands, not only the SW ones. Signed-off-by: Emmanuel Blot <[email protected]>
Function name was confusing. It may also be called when no CS change occurs. Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
Signed-off-by: Emmanuel Blot <[email protected]>
There may be more than on SPI device on a system Signed-off-by: Emmanuel Blot <[email protected]>
|
@jwnrt, @AlexJones0 this might also be useful for EG branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.