Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ot] scripts/opentitan: cfggen.py: fix regression introduced with bc4626ec #124

Merged

Conversation

rivos-eblot
Copy link

@rivos-eblot rivos-eblot commented Jan 28, 2025

  • ot-rom_ctrl table and ot-otp-eg.scrmbl_key had been removed.

OtpConfiguration was instantiated twice.

Also use a regular ordered dict (py3.7+) rather than a legacy OrderedDict for managing HJSON content.

…626e

- ot-rom_ctrl table and ot-otp-eg.scrmbl_key had been removed.

OtpConfiguration was instantiated twice.

Also use a regular ordered dict (py3.7+) rather than a legacy OrderedDict
for managing HSJON content.

Signed-off-by: Emmanuel Blot <[email protected]>
Copy link

@jwnrt jwnrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM

@rivos-eblot rivos-eblot merged commit 10ef4c7 into lowRISC:ot-earlgrey-9.1.0 Jan 28, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants