Skip to content

feat(pwa): per-app PWA icons/manifest, editor updates, and server endpoints #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 19 commits into from

Conversation

ElierHG
Copy link

@ElierHG ElierHG commented Aug 9, 2025

Summary

Introduce per-app PWA branding and icons across server and client:

  • Server endpoints for app icons and manifest access with appropriate public scope
  • Client support for maskable icons, editor and ApplicationV2 updates
  • Documentation for PWA icons/favicons in the app editor

Motivation

  • Brand-aware PWA install with proper icons (including maskable) and metadata per application
  • Improved favicon and manifest handling for the editor and installed apps
  • Developer guidance for configuring PWA assets

Changes

Server

  • Add per-app icon controller and endpoints
  • Refactor ApplicationController to enhance manifest/title handling
  • Adjust security to allow public access to PWA resources as needed
  • Add local-dev config
  • Update tests for new endpoints and logic

Client

  • Support per-app icon handling and conversion utilities
  • Improve editor view and ApplicationV2 to surface correct branding/icons
  • Add maskable icons and related manifest enhancements

Docs

  • Add guide: PWA icons and favicons for the app editor

Testing

  • Verified client pages render correct icons in editor and runtime
  • Confirmed maskable icons and manifest fields are present and valid
  • Exercised server endpoints for app icons and manifest with expected responses
  • Updated/ran related server tests

Backward compatibility

  • Additive; apps without custom icons fall back to defaults

Security

  • Manifest/icon endpoints intentionally public; other APIs unchanged

Commits (organized)

  • feat(pwa-server): per-app icon endpoints, manifest security scope, local-dev config; refactor ApplicationController; tests updated
  • feat(pwa-client): per-app PWA icon handling, maskable icons, editor display, ApplicationV2 updates; add icon conversion utils
  • docs(pwa): add PWA icons and favicons guide for app editor

Copy link

netlify bot commented Aug 9, 2025

👷 Deploy request for lowcoder-test pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit f1f3fd3

@ElierHG ElierHG marked this pull request as draft August 9, 2025 04:31
@ElierHG ElierHG marked this pull request as ready for review August 9, 2025 04:41
Elier Herrera added 2 commits August 9, 2025 07:15
…isplay, and ApplicationV2 updates; add icon conversion utils
…d local-dev config; refactor ApplicationController; tests updated
@ElierHG ElierHG closed this Aug 9, 2025
@ElierHG ElierHG deleted the pwa-icon-support branch August 9, 2025 11:50
@ElierHG
Copy link
Author

ElierHG commented Aug 9, 2025

Accidentally merged dev into this branch, will fix it and create new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants