Workspaces #64
Open
Workspaces #64
+6
−3,276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowlighter
requested changes
Jun 9, 2024
There was a problem hiding this comment.
The workspaces setting seems blocked by vercel-community/deno
Everything in .vscode/.github looks good to me so if you'd like to merge these changes now you could open a separate PR
As for the lint.tags I'd prefer keeping it less verbose since it's already the default
lishaduck
force-pushed
the
workspaces
branch
2 times, most recently
from
55a95c0
to
e7c01b1
Compare
lishaduck
commented
Jun 10, 2024
Deno workspaces enable JSR dependencies to resolve to local copies. This essentially turns all of the packages' tests into tests for `@libs/testing`.
|
Ok, it looks like it's not inheriting the fmt and lint configs. I'd assume that CI just needs to get bumped to 1.45. |
Hmm. CI should be using 1.45. Vercel deploys now, which is good. Hmm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deno is rolling out a new feature called workspaces.
It enables JSR monorepos to link to packages locally.
While
libsis far less interconnected thandeno_std, I figured that it might help if@libs/testinggot some extra "tests" by having all the packages link to the local copy in development.It should also enable a single dependency resolve and (probably) obsolete deno_config.ts, as I believe it automatically syncs formatting/linting/etc.