Fix color, personality, traits raw data extraction #1660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The banner were different for the personality and the traits, so the extraction was not working properly. Not sure about the color extraction, but added fallback colors for each types.
JujuDel
force-pushed
the
Fix_16personalities_plugin_getComputedStyle
branch
from
65bb99e
to
42674f3
Compare
|
Closing this PR in favor of #1661 The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 16Personalities plugin is currently giving an error. See #1601
I don't really know much about JS and EJS but tried to propose a fix over the weekend. Here is an example of the correction on my repo -> https://github.com/JujuDel/JujuDel/blob/master/metrics/metrics.plugin.16personalities.svg
I'll be happy to learn more about JS and best practices if I made something weird !
If I find time to implement + test it, I'll change the static SVG to a dynamic one (if that's even possible) because one of the figure is moving (e.g. here https://www.16personalities.com/profiles/7fd4a3833c7be)