Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v4l2 wrapper usage for 32 bit systems #31

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eifert
Copy link

@eifert eifert commented Dec 17, 2020

Hi,
when trying out rscam on Ubuntu 20.04 armhf (Armbian on BananaPI M1), I saw that the build with standard features (i.e. with the v4l wrappers) failed to mmap, while the "no_wrapper" build worked fine (but of course could not do any format conversions). Turns out that mmap and v4l_mmap have a nasty signature mismatch that's not reflected in rscam.

Mismatch brakes rscam on systems with 32-bit off_t.
Saw this on Ubuntu 20.04 armhf.
@loyd
Copy link
Owner

loyd commented Dec 26, 2020

Thank you for your contribution.

Does PR close #9?

src/v4l2.rs Outdated Show resolved Hide resolved
@eifert
Copy link
Author

eifert commented Dec 26, 2020

Thank you for your contribution.

Does PR close #9?

I can say that I got the same error message as the reporter, and this PR resolves the root cause of my error message. But chances are good that that issue has exactly the same root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants