Skip to content

Some cleanup and a couple of new features #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Some cleanup and a couple of new features #6

wants to merge 14 commits into from

Conversation

moorchegue
Copy link

This might be a bit messy to reviewb, but basically there are just a few changes:

  1. Constructor takes requests_kwargs and passes them to requests calls.
  2. Constructor takes response_wrapper which might be just a json.loads or something more fun to play with request object, response headers, etc.
  3. PaginatableResponse wrapper implemented to suck everything out of paginatable endpoint e.g. api.github.com/users. Examples provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moorchegue